Refactor: Honour page reload timer when live updates disabled

[Squidly271]

Summary by CodeRabbit

• Refactor
  • Streamlined the auto-refresh behavior, ensuring pages update consistently when reload settings are active.

[coderabbitai]

Walkthrough

The change updates a condition in the page layout logic used for reloading. Previously, the logic required both that the live update setting was not "no" and that the page load value was greater than 0. With this update, only the page load value is checked. No public or exported entities were altered.

Changes

File Path	Change Summary
emhttp/plugins/dynamix/.../DefaultPageLayout.php	Removed the $display['liveUpdate'] != "no" check; now only verifies if $myPage['Load'] > 0 before reloading.

Sequence Diagram(s)

sequenceDiagram
    participant PL as Page Layout
    participant JS as JavaScript Timer
    PL->>PL: Check: Is $myPage['Load'] > 0?
    alt Condition True
        PL->>JS: Set reload timer
    else Condition False
        PL->>PL: Skip timer setup
    end

Loading

Poem

I am a bunny with a curious sight,
Hopping through code from morning to night.
The live update check hopped away,
Now only loading makes the day.
With a twitch of my nose, I cheer the change bright! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc264d7 and 1a0b131.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix/include/DefaultPageLayout.php (1 hunks)

🔇 Additional comments (1)

emhttp/plugins/dynamix/include/DefaultPageLayout.php (1)

726-726: Simplifies page reload logic to honor the reload timer regardless of live update setting

This change correctly modifies the page reload logic to honor the $myPage['Load'] timer setting independently of the $display['liveUpdate'] setting, ensuring pages reload at their specified intervals even when live updates are disabled.

The conditional check if (nchanPaused === false) is still maintained, preventing reloads when the page is not in focus, which preserves the expected behavior for users.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.