rc.nginx: include path to monitor_nchan

[bergware]

rc.nginx can not find monitor_nchan

Summary by CodeRabbit

• Chores
  • Updated service management scripts to explicitly reference the monitoring command’s full path, ensuring clearer execution and reducing potential command resolution issues.

[coderabbitai]

Walkthrough

This pull request updates the etc/rc.d/rc.nginx script to explicitly reference the full path of the monitor_nchan executable. All calls to monitor_nchan in the nginx_start, nginx_stop, nginx_stop_forced, and nginx_reload functions have been modified to use /usr/local/sbin/monitor_nchan instead of relying on the shell's PATH resolution.

Changes

File	Change Summary
etc/rc.d/rc.nginx	Replaced all calls to monitor_nchan without a path with explicit references to /usr/local/sbin/monitor_nchan in start, stop, forced-stop, and reload functions.

Sequence Diagram(s)

sequenceDiagram
    participant Script as rc.nginx
    participant MN as monitor_nchan

    Script->>MN: /usr/local/sbin/monitor_nchan start
    Note over Script,MN: Called from nginx_start

    Script->>MN: /usr/local/sbin/monitor_nchan stop
    Note over Script,MN: Called from nginx_stop and nginx_reload

    Script->>MN: /usr/local/sbin/monitor_nchan stop remove
    Note over Script,MN: Called from nginx_stop_forced

Loading

Possibly related PRs

• More refinements #2102: Updates involving the monitor_nchan functionality in managing Nchan processes, which aligns with the modifications in this PR.

Poem

Oh, what hops of joy in my code land,
With paths explicit, my commands are grand!
I nibble on bytes and crunch through logs,
No more lost calls in the evening fog.
Cheers from the bunny, whiskers all a-glow!
🐰 CodeRabbit sings where clear paths flow!

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

etc/rc.d/rc.nginx (3)

716-716: Explicit Monitor Nchan Start in nginx_start

The command has been updated to call /usr/local/sbin/monitor_nchan start explicitly. This ensures that the correct executable is invoked regardless of the shell’s PATH. Consider verifying that the file exists and is executable in all target environments.

---

730-730: Use Full Path for Stopping Nchan Publishers in nginx_stop

The change to /usr/local/sbin/monitor_nchan stop is consistent with the PR objective and improves clarity on the executable’s location. It would be beneficial to ensure that the file’s existence and permissions are validated elsewhere if needed.

---

749-749: Force Stop with Explicit Path in nginx_stop_forced

Updating the call to /usr/local/sbin/monitor_nchan stop remove correctly specifies the absolute path. Please double-check that the arguments (stop remove) align with the expected behavior of the monitor_nchan utility.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8a142c and 2db077a.

📒 Files selected for processing (1)

• etc/rc.d/rc.nginx (5 hunks)

🔇 Additional comments (2)

etc/rc.d/rc.nginx (2)

781-781: Consistent Full Path Usage in nginx_reload (Pause Action)

The command /usr/local/sbin/monitor_nchan stop in the reload function is now explicitly defined, keeping consistency with other functions. This improves traceability across the script.

---

792-792: Resume Nchan Publishers Explicitly in nginx_reload

The updated call /usr/local/sbin/monitor_nchan start resumes nchan publishers with a clearly defined binary path. This meets the PR objective and ensures predictable behavior.