Skip to content

chore: sync all unraid-component files from api repo build#2111

Closed
zackspear wants to merge 4 commits into
unraid:masterfrom
zackspear:fix/ui-manifest-json
Closed

chore: sync all unraid-component files from api repo build#2111
zackspear wants to merge 4 commits into
unraid:masterfrom
zackspear:fix/ui-manifest-json

Conversation

@zackspear

@zackspear zackspear commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Introduced enhanced UI styling with responsive design, animations, and utility classes.
    • Added new configuration to streamline component registration and style management.
  • Updates

    • Updated client-side resource references to reflect the latest build output.
  • Chores

    • Removed an outdated metadata file to clean up configuration.

@coderabbitai

coderabbitai Bot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request removes the legacy manifest file from the unraid-components module, updates an existing manifest with revised client file references and a new timestamp, and introduces two new files in the UI directory. The new files include a CSS file with utility and responsive styles, and a JSON manifest mapping source files to their compiled outputs. These changes reflect a reorganization of asset tracking and improved management of UI component configurations.

Changes

File(s) Summary
emhttp/plugins/dynamix.my.servers/unraid-components/manifest.json Removed: Legacy manifest file with client JS and CSS references.
emhttp/plugins/dynamix.my.servers/unraid-components/nuxt/manifest.json Updated: Revised the "file" property from _nuxt/unraid-components.client-BXUDi12i.js to _nuxt/unraid-components.client-CC57q__k.js and updated the "ts" timestamp.
emhttp/plugins/dynamix.my.servers/unraid-components/uui/ui.CaW9jS_X.css
emhttp/plugins/dynamix.my.servers/unraid-components/uui/ui.manifest.json
Added: New CSS file with utility and responsive styling rules, and a corresponding manifest file defining entry points for UI components.

Possibly related PRs

Poem

I'm a little rabbit, hopping near and far,
Skipping old manifests and setting a brand new bar.
CSS and JSON now lead the way,
In our repo's garden, bright as day.
Hoppity hops and clean code dreams,
Celebrating change in our techy streams!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between f9d71fb and 1eadd99.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix.my.servers/unraid-components/nuxt/manifest.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • emhttp/plugins/dynamix.my.servers/unraid-components/nuxt/manifest.json

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
emhttp/plugins/dynamix.my.servers/unraid-components/uui/ui.CaW9jS_X.css (1)

1-2: New CSS File – Comprehensive Utility & Responsive Styles
This entirely new CSS file introduces a robust set of utility classes and responsive styles, supporting modern UI frameworks with utility-first principles. Note that static analysis hints flagged an "unexpected value or character" at the start and duplicate font names (e.g., potential duplicate entries for "Emoji" and "Segoe"). Please verify whether these warnings are false positives or if adjustments are needed to remove redundancies and ensure compliance with CSS best practices.

🧰 Tools
🪛 Biome (1.9.4)

[error] 1-1: Unexpected value or character.

Expected one of:

(parse)


[error] 1-1: Duplicate font names are redundant and unnecessary: Emoji

Remove duplicate font names within the property

(lint/suspicious/noDuplicateFontNames)


[error] 1-1: Duplicate font names are redundant and unnecessary: Segoe

Remove duplicate font names within the property

(lint/suspicious/noDuplicateFontNames)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ca9188 and f9d71fb.

⛔ Files ignored due to path filters (1)
  • emhttp/plugins/dynamix.my.servers/unraid-components/uui/register._OziqIBF.js.map is excluded by !**/*.map
📒 Files selected for processing (4)
  • emhttp/plugins/dynamix.my.servers/unraid-components/manifest.json (0 hunks)
  • emhttp/plugins/dynamix.my.servers/unraid-components/nuxt/manifest.json (1 hunks)
  • emhttp/plugins/dynamix.my.servers/unraid-components/uui/ui.CaW9jS_X.css (1 hunks)
  • emhttp/plugins/dynamix.my.servers/unraid-components/uui/ui.manifest.json (1 hunks)
💤 Files with no reviewable changes (1)
  • emhttp/plugins/dynamix.my.servers/unraid-components/manifest.json
🧰 Additional context used
🪛 Biome (1.9.4)
emhttp/plugins/dynamix.my.servers/unraid-components/uui/ui.CaW9jS_X.css

[error] 1-1: Unexpected value or character.

Expected one of:

(parse)


[error] 1-1: Duplicate font names are redundant and unnecessary: Emoji

Remove duplicate font names within the property

(lint/suspicious/noDuplicateFontNames)


[error] 1-1: Duplicate font names are redundant and unnecessary: Segoe

Remove duplicate font names within the property

(lint/suspicious/noDuplicateFontNames)

🔇 Additional comments (3)
emhttp/plugins/dynamix.my.servers/unraid-components/nuxt/manifest.json (2)

3-3: Updated Component File Name
The "file" property for the unraid-components.client entry has been updated from _nuxt/unraid-components.client-BXUDi12i.js to _nuxt/unraid-components.client-BDhuIo_x.js. Please ensure that all references to this file in the broader application (or dependency cache) have been updated accordingly.


11-11: Updated Timestamp
The "ts" property has been updated to 1743633846, which should now reflect the current build output’s timestamp. Verify that this change aligns with the intended caching and asset invalidation strategies in your deployment process.

emhttp/plugins/dynamix.my.servers/unraid-components/uui/ui.manifest.json (1)

1-12: New UI Manifest File Structure
This new JSON manifest cleanly maps source files to their compiled outputs. The entry for "src/register.ts" specifies an entry point with "isEntry": true and produces register._OziqIBF.js, while the "style.css" entry correctly links to the new CSS file ui.CaW9jS_X.css. The structure is clear and aligns with the updated organizational strategy.

@zackspear

Copy link
Copy Markdown
Contributor Author

found a regression. closing for now.

@zackspear zackspear closed this Apr 2, 2025
@zackspear

Copy link
Copy Markdown
Contributor Author

please find the new PR here #2113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant