Networking: fix duplicate metrics handling

[bergware]

Summary by CodeRabbit

• Refactor
  • Adjusted the duplicate metric validation so that checks occur after form fields are enabled for submission, streamlining the user input process while maintaining existing warning alerts for duplicate entries.
  • Enhanced the wireless connection setup and teardown processes for improved clarity and maintainability, including early return checks for wireless port existence and simplified handling of saved SSIDs.
  • Updated the identification of open networks in the WiFi scanning process for more concise code.

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1209939392697894

[coderabbitai]

Walkthrough

The changes involve modifications to the prepareSettings function in the Eth0.page file, where the duplicate metric validation logic has been relocated to execute after the form items are enabled for submission. The code defining the metrics and metrics6 arrays and the duplicate check has been moved, while the variables metric and metric6 have been removed for simplification. Additionally, the rc.wireless script's wifi_start and wifi_stop functions have been updated to improve error handling and streamline logic. Lastly, the scanWifi function in Wireless.php now uses a more concise syntax for identifying open networks.

Changes

File	Change Summary
emhttp/plugins/dynamix/Eth0.page	Moved duplicate metric validation (and related array initializations) within prepareSettings to execute after enabling form submission. Removed variables metric and metric6 to simplify the code.
etc/rc.d/rc.wireless	Inverted initial checks for wireless port existence in wifi_start and wifi_stop to return early if not found. Added WiFi enabled check in wifi_start. Simplified saved SSID handling and streamlined DHCP/DNS logic.
emhttp/plugins/dynamix/include/Wireless.php	Updated scanWifi function to use null coalescing assignment operator (??=) for identifying open networks, making the syntax more concise.

Sequence Diagram(s)

sequenceDiagram
    participant UI as User Interface
    participant PS as prepareSettings Function
    UI->>PS: Submit form
    PS->>PS: Enable form submission
    PS->>PS: Retrieve metric values (metrics, metrics6)
    PS->>PS: Validate duplicate metrics using same() method
    alt Duplicates Found
        PS->>UI: Display duplicate metrics warning 
    else No Duplicates
        PS->>UI: Proceed with saving settings
    end

Loading

Poem

I hopped through code with curious eyes,
Metrics now check after form gets its prize.
Duplicates are caught with a clever spin,
Variables pared down—simplicity wins!
Hopping on, I sing our code’s refined ties.
🐰💻✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 2f780b1 and bcc1287.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix/include/Wireless.php (1 hunks)

🔇 Additional comments (1)

emhttp/plugins/dynamix/include/Wireless.php (1)

51-51: Improved syntax for default value assignment.

The change from ?? to ??= (null coalescing assignment operator) provides a more concise way to set a default value for open networks. This is a good syntactic improvement while maintaining the same functionality.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.