File Manager and SMB style fixes#2150
Conversation
WalkthroughThis pull request updates the file management system by modifying regular expressions in the file move functions to include additional user share paths ( Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant BP as Browse.page (doAction/doActions)
participant FS as File System
U->>BP: Initiate file/folder move
BP->>BP: Validate path using updated regex
alt Valid Path
BP->>FS: Perform move operation
FS-->>BP: Return success
BP-->>U: Confirm success
else Invalid Path
BP-->>U: Return error message
end
sequenceDiagram
participant U as User
participant FT as FileTree
participant MD as my_dir
participant ND as no_dots
U->>FT: Request directory listing
FT->>MD: Determine directory path based on UD shares
MD-->>FT: Provide updated directory path
FT->>ND: Filter out '.' and '..' entries
ND-->>FT: Return cleaned directory list
FT-->>U: Send final listing
sequenceDiagram
participant U as User
participant RC as rc.wireless
participant WPA as wpa_supplicant
U->>RC: Request WiFi join with security mode
RC->>RC: Generate WPA config for multiple network blocks based on security mode
RC->>WPA: Restart wpa_supplicant with new config
WPA-->>RC: Confirm restart
RC-->>U: Confirm WiFi join success
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
- Make WPA3 enterprise work - Create mix configuration for WPA2/WPA3 networks (WPA3 preferred) - Improve automatic security selection
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
etc/rc.d/rc.wireless (1)
144-148: Clarify the logic for multi-network file creation
Currently,$FILEis assigned to either$WPAor$WPA.s, but then subsequent lines within the same function (e.g., line 152, 156, etc.) append configuration data to$WPA. This works in practice, thanks to line 171 appending$WPAback into$WPA.s. However, it can be confusing to new readers. Consider either using$FILEconsistently or adding a clarifying comment on why$WPAremains the main interim file.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
etc/rc.d/rc.wireless(2 hunks)
🔇 Additional comments (5)
etc/rc.d/rc.wireless (5)
141-141: No issues found for the new WPA3 Enterprise comment line
This added comment line is self-explanatory and doesn't introduce any problems.
152-152: Ensure comprehensive testing of WPA/Enterprise parameter assignments
These lines correctly separate open, PSK, SAE, and IEEE-based flows, includingieee80211wfor WPA3 or 802.1X/SHA-256. Verify in real-world testing that all security combinations (e.g., WPA2 vs. WPA3, 802.1X vs. SAE) work as intended and handle edge cases like older drivers or clients.Also applies to: 156-156, 162-162, 164-167, 171-171
263-269: Check priority ordering for the 'auto' security case
The block sets WPA3 Enterprise with the highest priority (25), followed by WPA2 Enterprise (18), WPA3 Personal (15), and WPA2 Personal (12). Confirm that this order matches the desired fallback logic for your environment.
270-279: WPA2/WPA3 Enterprise and Personal multi-network blocks
Generating multiple network blocks for WPA2/WPA3 modes ensures a seamless fallback from WPA3 to WPA2. The approach of writing to a temporary “.s” file and then moving it into$WPAis straightforward for configuring multiple security profiles.
283-284: Restarting wpa_supplicant
Killing any existing wpa_supplicant instance before spawning a new one provides a clean transition and avoids potential conflicts in reconfiguration.
2 participants
Summary by CodeRabbit
New Features
Style
Bug Fixes
User Interface