fix: diagnostics: prevent warnings for non-existent files, take 2

[ljm42]

Summary by CodeRabbit

• Refactor
  • Improved the process of collecting configuration files for diagnostics by handling each file type individually, ensuring more precise file selection and copying.

[coderabbitai]

Walkthrough

The update modifies a script responsible for collecting diagnostic configuration files. Previously, the script used a single glob pattern with GLOB_BRACE to match and copy files with .cfg, .conf, and .dat extensions in one step. The change replaces this with three separate glob operations and copy commands, each handling one file extension at a time. The process for copying the "go" file remains unchanged. No public or exported entity declarations were altered.

Changes

File(s)	Change Summary
emhttp/plugins/dynamix/scripts/diagnostics	Replaced a single multi-extension glob and copy operation with three separate glob and copy steps, each handling one file extension (.cfg, .conf, .dat) individually. The "go" file copy remains unchanged.

Possibly related PRs

• fix: diagnostics: prevent warnings for non-existent files #2176: Modifies file copying logic in the diagnostics script by adding existence checks before copying files, which is related to the current PR's focus on how files are selected and copied.

Poem

Three globs for three file types found,
Each now copied, extension-bound.
The script hops softly, step by step,
Gathering configs with careful prep.
A rabbit smiles at tidy code,
As diagnostics lighten their load! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e0e8671 and 60601f1.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix/scripts/diagnostics (1 hunks)

🔇 Additional comments (1)

emhttp/plugins/dynamix/scripts/diagnostics (1)

490-499: Effective solution to prevent warnings for non-existent files.

The change replaces a likely single glob operation using GLOB_BRACE with three separate conditional glob operations, each handling a specific file extension. This approach prevents warnings that would occur when trying to copy non-existent files, making the script more robust.

-run("cp -- /boot/config/*.{cfg,conf,dat} ".escapeshellarg("/$diag/config"));
+if (glob("/boot/config/*.cfg")) {
+  run("cp -- /boot/config/*.cfg ".escapeshellarg("/$diag/config"));
+}
+if (glob("/boot/config/*.conf")) {
+  run("cp -- /boot/config/*.conf ".escapeshellarg("/$diag/config"));
+}
+if (glob("/boot/config/*.dat")) {
+  run("cp -- /boot/config/*.dat ".escapeshellarg("/$diag/config"));
+}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.