Skip to content

Miscellaneous fixes#2209

Merged
limetech merged 4 commits into
unraid:masterfrom
bergware:master
May 28, 2025
Merged

Miscellaneous fixes#2209
limetech merged 4 commits into
unraid:masterfrom
bergware:master

Conversation

@bergware

@bergware bergware commented May 25, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the behavior of the "Enable default gateway" checkbox for IPv4 and IPv6 address assignments on network interfaces, ensuring the checkbox accurately reflects the current configuration.
  • New Features
    • Updated the custom network settings for Docker to limit the available subnet mask options for DHCP pool size, now allowing selection only from subnet masks 25 to 30.

@coderabbitai

coderabbitai Bot commented May 25, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The changes update network configuration UI logic. The Docker custom network subnet mask dropdown is restricted to smaller pool sizes (masks 25–30). Checkbox logic for enabling the default gateway on IPv4 interfaces is corrected in both Eth0 and EthX pages, ensuring the UI reflects the correct configuration state for each VLAN and base interface.

Changes

File(s) Change Summary
emhttp/plugins/dynamix.docker.manager/DockerSettings.page Limited DHCP pool subnet mask options from 16–30 to 25–30 in the IPv4 custom network configuration.
emhttp/plugins/dynamix/Eth0.page, emhttp/plugins/dynamix/EthX.page Fixed checkbox logic for "Enable default gateway" in IPv4 sections to use the correct configuration keys.

Possibly related PRs

  • Network enhancements #2045: Refined gateway enablement checkbox logic in Eth0.page and EthX.page, closely related to the current fixes for default gateway checkbox keys.

Poem

In the warren of wires, subnet masks shrink,
Now only small pools for Docker to link.
Gateways checked with careful eyes,
On every VLAN, no surprise.
The network’s more tidy, the UI more bright—
A rabbit’s delight in the soft glowing light! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a30172 and b756fc4.

📒 Files selected for processing (3)
  • emhttp/plugins/dynamix.docker.manager/DockerSettings.page (1 hunks)
  • emhttp/plugins/dynamix/Eth0.page (2 hunks)
  • emhttp/plugins/dynamix/EthX.page (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • emhttp/plugins/dynamix/EthX.page
🚧 Files skipped from review as they are similar to previous changes (2)
  • emhttp/plugins/dynamix.docker.manager/DockerSettings.page
  • emhttp/plugins/dynamix/Eth0.page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ljm42 ljm42 added the 7.2 label May 27, 2025
@limetech limetech merged commit a3d98a4 into unraid:master May 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants