feat: responsive improvements rd. 3#2212
Conversation
- Removed unnecessary margin adjustments for .vshift and .hshift classes in Eth0.css and default-base.css. - Added a new rule to fix the margin-top for UD titles to prevent overlapping with tabs.
|
""" WalkthroughThe updates remove several CSS classes and rules related to vertical and horizontal spacing adjustments, particularly those affecting Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
emhttp/plugins/dynamix/styles/default-base.css (1)
1956-1961: Approve targeted UD title override
This new rule effectively prevents the UD plugin’s titles from overlapping with the tabs, addressing the layout issue described in the PR. It aligns well with the PR objective to improve responsiveness and layout consistency.Nit: simplify and avoid
!important
- You can drop the
divtype qualifier and use.title.ud/#title.ud—class and ID selectors alone are sufficiently specific.- If possible, boost specificity (e.g., prefix with a parent selector) instead of resorting to
!important, which will make future overrides more predictable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
emhttp/plugins/dynamix/sheets/Eth0.css(0 hunks)emhttp/plugins/dynamix/styles/default-base.css(1 hunks)
💤 Files with no reviewable changes (1)
- emhttp/plugins/dynamix/sheets/Eth0.css
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript-typescript)
|
@coderabbitai the |
|
Tip For best results, initiate chat on the files or code changes. @zackspear Thank you for that clarification! That makes perfect sense - using 🐰💡 ✏️ Learnings added
|
- Removed text alignment from .nav-tile.right in default-base.css for better flex alignment. - Updated padding and width for #guiSearchBox in gui_search.css to enhance the search box layout. - Added a media query for #guiSearchBoxSpan to ensure consistent width on larger screens.
- Updated input value handling to use _var() for better security and consistency. - Refactored submit button logic to improve user experience by enabling/disabling based on AD join status. - Cleaned up form layout for better readability and maintainability.
…search.page - Removed the browser detection logic for improved code clarity and maintainability. - Updated the search functionality to use 'fragmentDirective' for better compatibility. - Eliminated the jQuery.mark.js file as it is no longer needed, streamlining the search implementation.
There was a problem hiding this comment.
Removed the browser detection as it's not needed any longer.
fragementDirective has been very well supported for a few years now, but we'll still check for it but even that is likely unnecessary these days.
https://caniuse.com/mdn-api_fragmentdirective
This allowed for the removal of the jquery.mark.js library and its usage.
- Eliminated an extra line break before the clone1 div to improve layout consistency and maintainability.
- Added CSS rules to remove top padding for the first form inside TableContainer elements, improving layout consistency.
- Adjusted HTML structure for better alignment and spacing of elements, enhancing overall readability. - Updated form input handling to ensure consistent presentation and user experience. - Cleaned up deprecated file system warnings and improved layout for various sections.
- Corrected inconsistent indentation in the processTitle function for improved code readability and maintainability.
- Adjusted indentation for the HTML structure of time selection elements, enhancing overall readability and consistency. - Ensured proper alignment of select elements for better user experience.
- Adjusted indentation and layout for various elements to enhance readability and maintain consistency. - Ensured proper alignment of titles and form elements for better user experience.
…ndling - Updated the plugin installation page to provide a console warning when no plugin file is selected, improving user feedback. - Added a file tree for easier selection of plugin files, enhancing user experience during plugin installation. - Adjusted the form layout for better alignment and consistency.
- Added logic to handle pages without titles but containing text, ensuring proper rendering of content. - Introduced a mechanism to skip index increment for such pages, maintaining correct tab functionality. - Improved code readability with better indentation and comments for clarity.
- Refactored navigation buttons in Share.page to use a more structured HTML layout, enhancing readability and user experience. - Updated ShareEdit.page to manage share setting clone responsively. - Deleted obsolete Share.css file to streamline styles and reduce clutter.
- Refactored HTML structure for read/write settings sections to improve layout and user experience. - Updated template for better clone settings - Adjusted form elements for improved alignment and spacing, enhancing overall readability.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
emhttp/plugins/dynamix.plugin.manager/PluginInstall.page (1)
27-27: Good improvement, but consider adding user-visible feedback as well.The console warning provides developer feedback when no plugin file is selected, which is better than silently returning. However, consider also displaying a user-visible message since end users may not check the browser console.
Consider enhancing the user feedback:
-if (!file) return console.warn('No plugin file selected'); +if (!file) { + console.warn('No plugin file selected'); + // Add user-visible feedback here, e.g., show an alert or highlight the input field + return; +}emhttp/plugins/dynamix/include/DefaultPageLayout/MainContentTabbed.php (1)
30-33: Good initialization with clear documentation.The variable initialization is well-documented and the purpose of
$skipIndexIncrementis clearly explained in the comment.Consider initializing the flag as part of the variable declaration for better locality:
<? $i = 0; - $skipIndexIncrement = false; // used if the page has no title but has text + $skipIndexIncrement = false; // Flag to skip index increment for pages with no title but with text ?>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
emhttp/plugins/dynamix.plugin.manager/PluginInstall.page(2 hunks)emhttp/plugins/dynamix.plugin.manager/Plugins.page(0 hunks)emhttp/plugins/dynamix/SecuritySMB.page(4 hunks)emhttp/plugins/dynamix/Share.page(1 hunks)emhttp/plugins/dynamix/ShareEdit.page(4 hunks)emhttp/plugins/dynamix/include/DefaultPageLayout/MainContentTabbed.php(3 hunks)emhttp/plugins/dynamix/sheets/Share.css(0 hunks)emhttp/plugins/dynamix/styles/default-base.css(4 hunks)emhttp/plugins/dynamix/styles/default-dynamix.css(1 hunks)
💤 Files with no reviewable changes (2)
- emhttp/plugins/dynamix/sheets/Share.css
- emhttp/plugins/dynamix.plugin.manager/Plugins.page
✅ Files skipped from review due to trivial changes (2)
- emhttp/plugins/dynamix/styles/default-dynamix.css
- emhttp/plugins/dynamix/SecuritySMB.page
🚧 Files skipped from review as they are similar to previous changes (2)
- emhttp/plugins/dynamix/ShareEdit.page
- emhttp/plugins/dynamix/styles/default-base.css
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (6)
emhttp/plugins/dynamix/Share.page (2)
50-59: LGTM! Good modernization with template literals.The refactoring to use ES6 template literals significantly improves code readability and maintainability. The HTML structure is clean and the CSS classes (
buttons-spaced,flex-shrink-0) align well with modern utility-based styling approaches.Security note: The interpolated PHP variables
<?=$prev?>and<?=$next?>are safely URL-encoded on lines 26-27, preventing XSS vulnerabilities.
62-63: Clean simplification of DOM manipulation.The simplified approach using template literals and direct append operation is much cleaner than the previous implementation. The conditional target selection logic correctly handles both tabbed and non-tabbed layouts.
emhttp/plugins/dynamix.plugin.manager/PluginInstall.page (2)
51-57: Excellent file browsing functionality implementation.The fileTree component is well-configured for plugin installation:
- Properly scoped to
/boot/directory (appropriate for Unraid plugin storage)- Correctly filtered to only show
.plgfiles for security- Clean callback that populates the input field automatically
This enhances user experience by allowing visual file selection instead of manual path entry.
62-62: Good styling improvement for better layout.The addition of
max-w-20 mx-autoCSS classes provides consistent styling with a maximum width constraint and center alignment, improving the form's visual presentation.emhttp/plugins/dynamix/include/DefaultPageLayout/MainContentTabbed.php (2)
7-7: Minor formatting improvement.The added blank line improves code readability by separating the header comment from the main content.
65-71: Robust flag management logic.The conditional increment logic correctly manages the tab index based on whether a page without title was processed. The flag is properly reset after use to prevent state leakage between iterations.
The approach ensures tab-content alignment remains correct when pages with no titles but with text are evaluated.
- Updated the HTML structure for the delete label and checkbox to improve alignment and user experience. - Adjusted the layout of surrounding elements for better visual consistency.
- Refactored HTML structure for read/write settings sections to improve layout and user experience. - Updated clone settings elements for better responsiveness - Updated form elements for better alignment and spacing, enhancing overall readability. - Introduced markdown support for improved formatting in the settings section.
- Wrapped the form element in a div for improved structure and layout. - Adjusted the closing div position to ensure proper HTML structure and readability.
|
No appetite for latest nitpicks. |
3 participants
Summary by CodeRabbit
Style
Bug Fixes
Chores