fix: add ServerState dependency to login page

[ljm42]

Prevents PHP fatal error

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability of login handling by ensuring necessary plugin state is loaded at the start of the login process.

[coderabbitai]

Walkthrough

A line was added at the start of a PHP script to include the state.php file from the dynamix.my.servers plugin directory. This change occurs before any session or cookie logic, with no other code or logic altered.

Changes

File(s)	Change Summary
emhttp/plugins/dynamix/include/.login.php	Added an include statement for state.php at top

Possibly related PRs

• fix: PHP Warning in state.php #2009: Adds an include of state.php in .login.php, while the related PR modifies a method signature inside state.php; both PRs interact with the same file.

Suggested labels

7.2

Suggested reviewers

• zackspear

Poem

A bunny hopped in, quick and neat,
To add an include—oh, what a feat!
Before cookies or sessions could even begin,
state.php now joins right in.
With every hop, the code grows strong,
In the meadow of plugins, we all belong! 🐇

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

emhttp/plugins/dynamix/include/.login.php (1)

4-4: Include state.php to satisfy ServerState dependency.
The added

require_once "$docroot/plugins/dynamix.my.servers/include/state.php";

ensures that the ServerState class is available before any session or SSO logic, which aligns with the PR objective to prevent the PHP fatal error.

Optional: Graceful degradation if the plugin is absent.
If the dynamix.my.servers plugin may not always be installed, you could guard the include to avoid a fatal error and let the login page continue to operate without SSO support:

-$stateFile = "$docroot/plugins/dynamix.my.servers/include/state.php";
-require_once $stateFile;
+$stateFile = "$docroot/plugins/dynamix.my.servers/include/state.php";
+if (file_exists($stateFile)) {
+    require_once $stateFile;
+}

Verify $docroot initialization
Confirm that the main login.php (which includes this file) sets $docroot before this require_once call, so the path resolves correctly at runtime.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b08c70a and 6487377.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix/include/.login.php (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript-typescript)