Miscellaneous updates#2224
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ## Walkthrough
The update refactors logic in ArrayOperation.page by introducing a new `$auto` variable to represent when the filesystem type is `'auto'`, expanding LUKS state evaluation to include such disks. Separately, Wrappers.php receives stylistic and formatting improvements without altering any logic or control flow. Minor changes were made in DockerContainers.php to adjust punctuation in the Tailscale version update message. Additionally, XML_Expert.form.php was updated for whitespace cleanup and prompt text formatting. VMajax.php and Custom.form.php were improved for internationalization and formatting without changing logic.
## Changes
| File(s) | Change Summary |
|-------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------|
| emhttp/plugins/dynamix/ArrayOperation.page | Refactored to introduce `$auto` for `'auto'` fsType, expanding LUKS state checks to include these. |
| emhttp/plugins/dynamix/include/Wrappers.php, emhttp/plugins/dynamix.vm.manager/include/VMajax.php | Stylistic, formatting, and internationalization improvements; no logic or control flow changes. |
| emhttp/plugins/dynamix.docker.manager/include/DockerContainers.php | Adjusted punctuation placement in Tailscale update notification string. |
| emhttp/plugins/dynamix.vm.manager/templates/XML_Expert.form.php | Whitespace cleanup and modified SweetAlert prompt text formatting without logic changes. |
| emhttp/plugins/dynamix.vm.manager/templates/Custom.form.php | Updated warning message rendering for snapshot rename disablement with proper localization and formatting. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant ArrayOperation.page
participant Disk
participant LUKS
User->>ArrayOperation.page: Initiate disk operation
ArrayOperation.page->>Disk: Check fsType and luks prefix
alt fsType is 'auto' or luks prefix present
ArrayOperation.page->>LUKS: Evaluate luksState
LUKS-->>ArrayOperation.page: Return luksState
end
ArrayOperation.page-->>User: Present disk statePossibly related PRs
Suggested reviewers
Poem
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Refactor
Style
Bug Fix
User Interface
Internationalization