fix: ui-dialog min and max sizes#2271
Conversation
- Set width to 100% and max-width to 100rem for better layout control. - Adjusted min-height to 35vh while maintaining max-height at 70vh for enhanced flexibility. This change aims to improve the responsiveness of the icon-zip component.
WalkthroughThe CSS for the Changes
Suggested labels
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
emhttp/plugins/dynamix/styles/default-dynamix.css (1)
1480-1482: Height constraints: add a graceful fallback path
min-height: 35vh !important;paired withmax-height: 70vh !important;improves readability but again ignores the dynamic height jQuery-UI may compute based on content. Additionally, some very small screens (≤ 500 px height) will get a minimum of ~175 px, potentially causing vertical overflow together with header/footer chrome.Consider:
- Switching to
clamp()– e.g.height: clamp(175px, 35vh, 70vh);– which preserves your intent while avoiding excessive growth on tiny displays.- Dropping
!importantunless absolutely necessary.- min-height: 35vh !important; - max-height: 70vh !important; + /* 35 vh floor, 70 vh ceiling, but never below 175 px on very small viewports */ + height: clamp(175px, 35vh, 70vh);Run visual tests on mobile portrait and desktop to ensure no scroll-locking issues occur.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
emhttp/plugins/dynamix/styles/default-dynamix.css(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
emhttp/plugins/dynamix/styles/default-dynamix.css (1)
1468-1470: ```shell
#!/bin/bashExtract the surrounding CSS rule for context around the width override
sed -n '1450,1500p' emhttp/plugins/dynamix/styles/default-dynamix.css
</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Summary by CodeRabbit