fix: do not run crowdin workflow on forked repos#2307
Conversation
WalkthroughA conditional expression was added to the GitHub Actions workflow Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/crowdin-upload.yml (1)
11-14: Prefer explicit expression syntax for theifguard
if: github.repository == 'unraid/webgui'works, but surrounding the whole condition with${{ … }}is the convention used throughout most GitHub-Actions docs and avoids any accidental mis-parsing (e.g., when a value starts with!or>). It also makes the line grep-friendly for automated checks.- if: github.repository == 'unraid/webgui' + if: ${{ github.repository == 'unraid/webgui' }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/crowdin-upload.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: zackspear
PR: unraid/webgui#2099
File: emhttp/plugins/dynamix.my.servers/include/activation-code-extractor.php:128-134
Timestamp: 2025-03-27T22:03:42.934Z
Learning: Files synchronized from other repositories as part of the "align shared .page, php, scripts, & web components with api repo" PR should not be modified directly in the destination repository to maintain alignment between repositories.
Learnt from: dlandon
PR: unraid/webgui#2035
File: emhttp/plugins/dynamix/SyslogFilter.page:19-26
Timestamp: 2025-02-27T21:52:42.541Z
Learning: In the unraid/webgui repository, basic error handling is sufficient for file operations like checking file existence and using the @ operator to suppress errors, without additional error messages or notifications.
Learnt from: SimonFair
PR: unraid/webgui#1992
File: emhttp/plugins/dynamix/include/CPUset.php:0-0
Timestamp: 2025-02-01T15:12:16.914Z
Learning: In the unRAID WebGUI, button text should be wrapped in _() for translation support and htmlspecialchars() for security, with a preference for using ternary operators for simple conditional text assignments.
.github/workflows/crowdin-upload.yml (2)
Learnt from: dlandon
PR: #2035
File: emhttp/plugins/dynamix/SyslogFilter.page:19-26
Timestamp: 2025-02-27T21:52:42.541Z
Learning: In the unraid/webgui repository, basic error handling is sufficient for file operations like checking file existence and using the @ operator to suppress errors, without additional error messages or notifications.
Learnt from: dlandon
PR: #2035
File: etc/rc.d/rc.rsyslogd:48-50
Timestamp: 2025-02-27T21:53:37.589Z
Learning: For the unraid/webgui project, simple error handling is preferred over extensive error checking in shell scripts. The copy operation for configuration files like in rc.rsyslogd doesn't require additional error logging, permission checks, or return statements.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript-typescript)
2 participants
Summary by CodeRabbit