fix: do not attempt to parse response as json, just look for exact va…

[elibosley]

…lidity

Summary by CodeRabbit

• Bug Fixes

  • Improved reliability of SSO token verification during login.

• Style

  • Enhanced formatting for error messages related to login attempt limits for better readability.

[coderabbitai]

Walkthrough

The verification logic for SSO token responses in the login process was simplified by replacing JSON parsing with a substring check for "valid":true. Minor formatting adjustments were also made to error message concatenations. No changes were made to function signatures or the overall control flow.

Changes

Cohort / File(s)	Change Summary
Login SSO Verification and Formatting emhttp/plugins/dynamix/include/.login.php	Simplified SSO token response verification by checking for a substring instead of parsing JSON; adjusted string concatenation formatting in error messages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Suggested labels

7.2

Suggested reviewers

• zackspear

Poem

A bunny hopped through login code,
Where SSO checks once heavily strode.
Now, with a simpler string to find,
The logic’s light and well-aligned.
With spaces neat and errors clear,
Reviewers’ work is easier here!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 374cce9 and 6fc7ebd.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix/include/.login.php (3 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: dlandon
PR: unraid/webgui#2035
File: emhttp/plugins/dynamix/SyslogFilter.page:19-26
Timestamp: 2025-02-27T21:52:42.541Z
Learning: In the unraid/webgui repository, basic error handling is sufficient for file operations like checking file existence and using the @ operator to suppress errors, without additional error messages or notifications.

Learnt from: zackspear
PR: unraid/webgui#0
File: :0-0
Timestamp: 2025-05-31T00:04:34.204Z
Learning: For the unraid/webgui legacy codebase, ARIA labels and accessibility concerns should not be addressed in individual PRs. These will be handled via a different solution in the future.

emhttp/plugins/dynamix/include/.login.php (1)

Learnt from: Squidly271
PR: #2264
File: emhttp/plugins/dynamix/include/.login.php:0-0
Timestamp: 2025-06-18T17:09:35.579Z
Learning: In the Unraid webGUI login system (emhttp/plugins/dynamix/include/.login.php), the cooldown timer restarting on page reload during the cooldown period is intentional behavior, not a bug. When a form is resubmitted during cooldown, the timer should restart to provide consistent user feedback.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

emhttp/plugins/dynamix/include/.login.php (3)

127-134: LGTM: Simplified SSO token validation approach

The change from JSON parsing to substring matching for "valid":true is a practical approach that avoids potential JSON parsing errors while maintaining the same validation outcome. The concatenation of output lines ensures the check works regardless of line breaks in the response.

---

161-161: LGTM: Improved string concatenation formatting

Adding spaces around the concatenation operator improves code readability and maintains consistency with PHP coding standards.

---

190-190: LGTM: Consistent string concatenation formatting

The spacing around the concatenation operator matches the formatting improvement made on line 161, maintaining consistency throughout the codebase.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/check-response-directly

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.