update compiler for XLMRobertaModel

[electroglyph]

This fixes an issue when trying to compile XLMRobertaModel.

the XLMRobertaModel models have a "forward" entry in their dir(), but they are not classes, so issubclass fails.

this just adds a check to make sure issubclass is only used on classes.

[gemini-code-assist]

Summary of Changes

Hello @electroglyph, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compilation error encountered with XLMRobertaModel by refining the type checking logic within the compiler. It ensures that the issubclass function is only invoked on actual class types, preventing failures that occurred when non-class objects (like XLMRobertaModel instances) incorrectly exposed a forward attribute, leading to an invalid issubclass call.

Highlights

• Compilation Fix: Resolves a compilation issue specifically affecting XLMRobertaModel by preventing issubclass from being called on non-class objects.
• Type Safety: Introduces an explicit type check using isinstance(module_class, type) to ensure that issubclass is only invoked when module_class is indeed a class type.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a TypeError when compiling XLMRobertaModel by adding a check to ensure issubclass is called on a class. The change is effective. I've also added a couple of review comments pointing out opportunities to improve the surrounding code for better security and robustness by replacing an eval() call and specifying exceptions in a try...except block.

[gemini-code-assist]

Your fix is correct for the reported issue. However, the preceding line's use of eval() is a security concern and is considered bad practice. It's safer and more idiomatic to use getattr() to access object attributes dynamically.

Consider replacing line 2665:

module_class = eval(f"modeling_file.{module}")

with:

module_class = getattr(modeling_file, module)

[gemini-code-assist]

In this same block, the bare except: on line 2669 is too broad. It can catch any exception, including SystemExit or KeyboardInterrupt, which can make debugging difficult and hide bugs. It's best practice to catch only the specific exceptions you expect. inspect.getsource is documented to raise TypeError or OSError.

Consider changing line 2669:

except:

to:

except (TypeError, OSError):