Skip to content

code cleanup, add unit tests, hook up eslint and prettier #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olblak merged 20 commits into from
Jul 22, 2022
Merged

code cleanup, add unit tests, hook up eslint and prettier #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d381e95
cleanup logic and hook up eslint and prettier
jetersen Jul 21, 2022
11ff0af
core.addPath is called in updatecliVersion
jetersen Jul 21, 2022
41c395a
convert to module and use unicorn
jetersen Jul 21, 2022
54480e5
format
jetersen Jul 21, 2022
a224bf1
tool-cache has sensible default for arch
jetersen Jul 21, 2022
7d3f46e
move core.addPath to updatecliDownload
jetersen Jul 21, 2022
4085d78
syntax
jetersen Jul 21, 2022
e09aa16
syntax and prefer linux first in conditions
jetersen Jul 21, 2022
07c4c7b
dist
jetersen Jul 21, 2022
3743afa
fully testable
jetersen Jul 21, 2022
26115ed
fix lint
jetersen Jul 21, 2022
6f6c100
cleanup test code
jetersen Jul 21, 2022
3b1ae8c
fix import
jetersen Jul 21, 2022
2317978
run tests
jetersen Jul 21, 2022
7a27446
make method testable when throwing exception
jetersen Jul 21, 2022
bdee5ed
dist
jetersen Jul 21, 2022
199cf74
check exitcode for run
jetersen Jul 21, 2022
ac4c504
fix exit code test
jetersen Jul 21, 2022
dc38040
Merge branch 'v2' into cleanupLogic
jetersen Jul 21, 2022
aae16d3
add updatecli target
jetersen Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 24 additions & 16 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,26 @@
{
"env": {
"commonjs": true,
"es6": true,
"jest": true,
"node": true
},
"extends": "eslint:recommended",
"globals": {
"Atomics": "readonly",
"SharedArrayBuffer": "readonly"
},
"parserOptions": {
"ecmaVersion": 2018
},
"rules": {
}
"env": {
"commonjs": true,
"es6": true,
"jest": true,
"node": true
},
"ignorePatterns": [
"**/node_modules/",
"coverage/**"
],
"extends": [
"eslint:recommended",
"plugin:prettier/recommended",
"plugin:unicorn/recommended"
],
"globals": {
"Atomics": "readonly",
"SharedArrayBuffer": "readonly"
},
"parserOptions": {
"ecmaVersion": 2022,
"sourceType": "module"
},
"rules": {}
}
2 changes: 2 additions & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ jobs:

- run: npm ci

- run: npm test

e2e:
name: Test Updatecli Github Action
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,6 @@ typings/

# next.js build output
.next

CACHE/
TEMP/
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
dist/
lib/
node_modules/
coverage/
2 changes: 1 addition & 1 deletion .prettierrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"useTabs": false,
"semi": false,
"singleQuote": true,
"trailingComma": "none",
"trailingComma": "es5",
"bracketSpacing": false,
"arrowParens": "avoid"
}
Loading