Update CI pipeline by Theosakamg · Pull Request #4 · upsun/upsun-sdk-node

Theosakamg · 2025-11-17T11:09:22Z

No description provided.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

solve issue with discriminator generating import doublon

…urn correct headers.Autorization

…andling

templates/node/runtime.mustache

Add new tasks

Copilot

Pull request overview

This PR performs a major refactoring of the CI pipeline and codebase structure for the Upsun SDK for Node.js. The changes include:

Modernized CI/CD: New GitHub Actions workflows with better separation of concerns (quality, tests, doc, coverage, build)
Renamed task classes: Changed from singular to plural naming (e.g., ActivityTask → ActivitiesTask, BackupTask → BackupsTask)
Updated configuration: Added Jest, ESLint, Prettier, and TypeScript test configuration
Improved project structure: Better organization with new index files and separation of concerns
Enhanced tooling: Updated npm scripts for better development workflow

Changes:

Migrated from singular to plural naming for all task classes and test files
Added comprehensive CI/CD workflows with quality checks, testing across multiple Node.js versions, and documentation generation
Introduced OpenAPI Generator templates for better code generation
Updated all import paths to reflect the new structure
Added new configuration files for testing, linting, and formatting

Reviewed changes

Copilot reviewed 123 out of 128 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
`.github/workflows/develop.yml`	New PR review workflow with quality checks, tests, doc, and coverage
`.github/workflows/publish.yml`	Updated release workflow with documentation and coverage steps
`jest.config.js`	New Jest configuration with ESM support and coverage settings
`eslint.config.js`	New ESLint configuration using TypeScript ESLint
`tsconfig.test.json`	New TypeScript configuration for tests
`package.json`	Updated scripts for improved development workflow
`tests/unit/*/.test.ts`	Renamed and updated test files (singular → plural)
`src/core/tasks/*/.ts`	Renamed and refactored task files with plural naming
`src/core/tasks/task_base.ts`	Expanded validation methods
`src/core/index.ts`	Reorganized exports
`src/index.ts`	Simplified main entry point
`templates/*/.mustache`	Added OpenAPI Generator templates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-13T16:16:26Z

src/app.ts

+import {
+  DedicatedDeploymentTargetCreateInputTypeEnum,
+  SubscriptionStatusEnum,
+} from './model/index.js';


Unused imports DedicatedDeploymentTargetCreateInputTypeEnum, SubscriptionStatusEnum.

Suggested change

import {

DedicatedDeploymentTargetCreateInputTypeEnum,

SubscriptionStatusEnum,

} from './model/index.js';

Copilot · 2026-02-13T16:16:26Z

src/app.ts

+} from './model/index.js';
+import { UpsunClient, UpsunConfig } from './upsun.js';
+import dotenv from 'dotenv';
+import { ResponseError } from './index.js';


Unused import ResponseError.

Suggested change

import { ResponseError } from './index.js';

Copilot · 2026-02-13T16:16:26Z

src/app.ts

+function delay(ms: number): Promise<void> {
+  return new Promise(resolve => setTimeout(resolve, ms));
 }



Unused function delay.

Suggested change

function delay(ms: number): Promise<void> {

return new Promise(resolve => setTimeout(resolve, ms));

}

Copilot · 2026-02-13T16:16:27Z

src/app.ts

-const orgName = "Perso-home"; // Replace with your organization ID
-const org = orgs.items?.find((p) => p.label === orgName) ?? null;
-console.log(org);
+const relationships = await upsun.environments.getDeployment(projectTestId, 'main', 'current');


Unused variable relationships.

Suggested change

const relationships = await upsun.environments.getDeployment(projectTestId, 'main', 'current');

await upsun.environments.getDeployment(projectTestId, 'main', 'current');

Copilot · 2026-02-13T16:16:27Z

src/app.ts

+const mountsWebapps = await upsun.mounts.list(
+  projectTestId,
+  'main',
+  DeploymentResourceGroup.webapps,
+);


Unused variable mountsWebapps.

Suggested change

const mountsWebapps = await upsun.mounts.list(

projectTestId,

'main',

DeploymentResourceGroup.webapps,

);

Copilot · 2026-02-13T16:16:28Z

src/app.ts

        console.log(res);

+        console.log('--- Set Resources ---');
+        const response = await upsun.resources.set(


Unused variable response.

Suggested change

const response = await upsun.resources.set(

await upsun.resources.set(

Copilot · 2026-02-13T16:16:28Z

src/core/tasks/projects.ts

+import {
+  AcceptedResponse,
+  Activity,
+  CanCreateNewOrgSubscription200Response,
+  EnvironmentVariableCreateInput,
+  Project,
+  ProjectCapabilities,
+  ProjectPatch,
+  ProjectSettings,
+  ProjectVariable,
+  Subscription,
+  Blob,
+  Commit,
+  Ref,
+  Tree,
+  SystemInformation,
+  Domain,
+  Certificate,
+  TeamProjectAccess,
+  GrantProjectTeamAccessRequestInner,
+  GrantTeamProjectAccessRequestInner,
+  ListProjectTeamAccess200Response,
+  DomainPatch,
+  UserProjectAccess,
+  GrantProjectUserAccessRequestInner,
+  ListProjectUserAccess200Response,
+  Environment,
+  ProjectInvitation,
+  ListOrgProjects200Response,
+} from '../../model/index.js';


Unused imports Blob, Commit, Ref, SystemInformation, Tree.

Copilot · 2026-02-13T16:16:29Z

src/core/tasks/repositories.ts

@@ -0,0 +1,121 @@
+import { UpsunClient } from '../../upsun.js';
+import { Blob, Commit, Metrics, Ref, SystemInformation, Tree } from '../../model/index.js';


Unused import Metrics.

Copilot · 2026-02-13T16:16:29Z

src/upsun.ts

+import {
+  AddOnsApi,
+  ApiTokensApi,
+  AutoscalingApi,
+  CertManagementApi,
+  ConnectionsApi,
+  DeploymentApi,
+  DeploymentTargetApi,
+  DomainManagementApi,
+  EnvironmentActivityApi,
+  EnvironmentApi,
+  EnvironmentBackupsApi,
+  EnvironmentTypeApi,
+  EnvironmentVariablesApi,
+  GrantsApi,
+  Integrations,
+  InvoicesApi,
+  MfaApi,
+  OrdersApi,
+  OrganizationInvitationsApi,
+  OrganizationMembersApi,
+  OrganizationProjectsApi,
+  OrganizationsApi,
+  PhoneNumberApi,
+  ProfilesApi,
+  ProjectActivityApi,
+  ProjectApi,
+  ProjectInvitationsApi,
+  ProjectSettingsApi,
+  ProjectVariablesApi,
+  RecordsApi,
+  RepositoryApi,
+  RoutingApi,
+  RuntimeOperationsApi,
+  SourceOperationsApi,
+  SshKeysApi,
+  SubscriptionsApi,
+  SystemInformationApi,
+  TeamAccessApi,
+  TeamsApi,
+  ThirdPartyIntegrationsApi,
+  UserAccessApi,
+  UserProfilesApi,
+  UsersApi,
+  VouchersApi,
+} from './index.js';


Unused imports DeploymentTargetApi, Integrations.

Copilot · 2026-02-13T16:16:29Z

src/core/oauth-provider.ts

+
+    if (!response.ok) {
+      throw new Error('Token exchange failed');
+      return false;


This statement is unreachable.

Suggested change

return false;

Update CI pipeline

bc6c643

Theosakamg force-pushed the ci_std branch from 7804931 to bc6c643 Compare November 17, 2025 11:14

Theosakamg and others added 24 commits November 17, 2025 21:16

Fix core for new generator templates

c69e1ad

Add custom Templates for node

bf9a79a

Fix .gitignore for github action

1520b11

solve issue with discriminator generating import doublon

fefe6e0

Update templates/node/modelGeneric.mustache

6d6d432

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

add openapispec-upsun.json

294d5b9

remove mustache comment

70d5f1b

remove debug comment

4803558

only support latest LTS

ed137fa

solve doc action issue

91ec3dd

Merge pull request #5 from upsun/fix-discriminator

c5c0fea

solve issue with discriminator generating import doublon

update runtime.mustache to take in account accessTokenFactory and ret…

c743bff

…urn correct headers.Autorization

add project.delete (with Subsbscription management) + improve error h…

5d3f9ba

…andling

solve upsun.resources.get and upsun.resources.set

d720032

backup.restore test + certificate.update function+test

c981f58

solve certificate.update params + tests

030dabf

using plural for all task names

ccd5afc

DomainsTask: add with all parameters + update solved + tests

ccc60a2

VariablesTask done (still need tests)

e42b414

EnvironmentTask: complete (with TODO) + tests

da2e517

TeamsTask function complete (test in progress)

2084220

review with Mickael till environments.ts

22c2563

lint errors solved

2b5af08

app.ts

9c1b424

flovntp reviewed Feb 6, 2026

View reviewed changes

templates/node/runtime.mustache Show resolved Hide resolved

flovntp added 3 commits February 9, 2026 09:48

align constructor + change upsun.ts init

78e1d12

OrganizationTask function complete (todo tests)

f40ca1e

UsersTask function+comments (todo tests)

ced511e

flovntp and others added 17 commits February 13, 2026 15:38

test fails

e3283c6

test fails

25b9eba

test fails

9b5e364

test fails

fb10ec1

tsconfig with rootdir.

9cd34fe

test fails

b15535b

test fails

92042ce

isolatedModules

4e9b961

adding .js in model.js

342e695

test fails

e1aaabe

test fails

f02fde7

bundler

1cbea38

readd .js

12b6424

deactivate test for now

24fb21f

revert tsconfig

7266b11

node version 25

bce2cdb

Merge pull request #6 from upsun/fhk_ci_std

4816a26

Add new tasks

Theosakamg force-pushed the ci_std branch 5 times, most recently from 292c096 to afb3896 Compare February 13, 2026 16:08

Theosakamg requested a review from Copilot February 13, 2026 16:13

Copilot started reviewing on behalf of Theosakamg February 13, 2026 16:14 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

Theosakamg force-pushed the ci_std branch 2 times, most recently from ab42d67 to 92244d4 Compare February 13, 2026 16:29

Fix build

4e35076

Theosakamg force-pushed the ci_std branch from 92244d4 to 4e35076 Compare February 13, 2026 16:30

Theosakamg merged commit 99b419e into main Feb 13, 2026
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CI pipeline#4

Update CI pipeline#4
Theosakamg merged 70 commits intomainfrom
ci_std

Theosakamg commented Nov 17, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	function delay(ms: number): Promise<void> {
	return new Promise(resolve => setTimeout(resolve, ms));
	}

	const relationships = await upsun.environments.getDeployment(projectTestId, 'main', 'current');
	await upsun.environments.getDeployment(projectTestId, 'main', 'current');

	const response = await upsun.resources.set(
	await upsun.resources.set(

		@@ -0,0 +1,121 @@
		import { UpsunClient } from '../../upsun.js';
		import { Blob, Commit, Metrics, Ref, SystemInformation, Tree } from '../../model/index.js';

Conversation

Theosakamg commented Nov 17, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants