Fix maxFeePerGas < maxPriorityFeePerGas transaction issue#1139
Merged
master-malwyl merged 2 commits intomasterfrom Feb 12, 2025
Merged
Fix maxFeePerGas < maxPriorityFeePerGas transaction issue#1139master-malwyl merged 2 commits intomasterfrom
master-malwyl merged 2 commits intomasterfrom
Conversation
resolves #1136 Replaced legacy gas calculation which sometimes caused maxFeePerGas to be less than maxPriorityFeePerGas.
Contributor
|
One minor suggestion: we might want to add an explicit error case if both 'pending' and 'latest' blocks fail to return baseFeePerGas: let block = await web3.eth.getBlock('pending');
// in case pending block doesn't return anything
if (!block || !block.baseFeePerGas) {
block = await web3.eth.getBlock('latest');
if (!block || !block.baseFeePerGas) {
throw new Error('Unable to fetch baseFeePerGas from network');
}
}This would make debugging easier if we ever hit an edge case where the network isn't returning proper EIP-1559 data. Otherwise, the changes look good and should fix the issues reported in #1136. |
- Cleaner format + error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1136
Replaced legacy gas calculation that sometimes caused maxFeePerGas to be less than maxPriorityFeePerGas.
Previous code used web3.eth.getGasPrice() to calculate maxFeePerGas, which isn't suitable anymore for EIP-1559 transactions. Now fetching 'baseFeePerGas' instead.