feat(config): pass rlimits to urunit via UCS#353
feat(config): pass rlimits to urunit via UCS#353codesmith25103 wants to merge 1 commit intourunc-dev:mainfrom
Conversation
✅ Deploy Preview for urunc canceled.
|
|
@cmainas Can you guide me why these two test cases are getting failed? |
These are both linting errors, because of spelling. I think updating https://github.com/urunc-dev/urunc/blob/main/.github/linters/urunc-dict.txt should be enough.
|
8d58b89 to
fb24736
Compare
This extracts the rlimits from the OCI spec in the unikontainer logic and appends them to the UCS configuration block generated in linux.go. This allows the guest init process (urunit) to enforce resource limits. Signed-off-by: Sankalp <sankalp25103@gmail.com>
fb24736 to
be0d065
Compare
|
cmainas
left a comment
There was a problem hiding this comment.
Hello @codesmith25103 , in order for these changes to be effective, we also need to update urunit to parse the updated config and apply the rlimits to the process. Therefore, we can not merge this without urunit supporting them. If you want you can also try to implement the necessary changes in urunit too. Otherwise, I will work on it when I find time to do so.
|
@cmainas I will try to update urunit and will update this PR. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
|
This PR was closed because it has been stalled for 75 days with no activity. |



feat(unikernels): pass rlimits to urunit via UCS
This adds support for passing rlimits from the OCI spec to the
guest VM by appending them to the UCS configuration block.
Fixes #312