Skip to content

feat(config): pass rlimits to urunit via UCS#353

Closed
codesmith25103 wants to merge 1 commit intourunc-dev:mainfrom
codesmith25103:Issue312
Closed

feat(config): pass rlimits to urunit via UCS#353
codesmith25103 wants to merge 1 commit intourunc-dev:mainfrom
codesmith25103:Issue312

Conversation

@codesmith25103
Copy link
Copy Markdown
Contributor

feat(unikernels): pass rlimits to urunit via UCS

This adds support for passing rlimits from the OCI spec to the
guest VM by appending them to the UCS configuration block.

Fixes #312

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 13, 2025

Deploy Preview for urunc canceled.

Name Link
🔨 Latest commit be0d065
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/694abd4704823a0008c14f34

@codesmith25103
Copy link
Copy Markdown
Contributor Author

@cmainas Can you guide me why these two test cases are getting failed?

@cmainas
Copy link
Copy Markdown
Contributor

cmainas commented Dec 15, 2025

@cmainas Can you guide me why these two test cases are getting failed?

These are both linting errors, because of spelling. I think updating https://github.com/urunc-dev/urunc/blob/main/.github/linters/urunc-dict.txt should be enough.

  • For Lint Commit Messages
Run git fetch origin main --depth=1
From https://github.com/urunc-dev/urunc
 * branch            main       -> FETCH_HEAD
 * [new branch]      main       -> origin/main
⧗   input: feat(config): pass rlimits to urunit via UCS

This extracts the rlimits from the OCI spec in the unikontainer
logic and appends them to the UCS configuration block generated
in linux.go. This allows the guest init process (urunit) to
enforce resource limits.

Fixes #253
Signed-off-by: Sankalp <sankalp25103@gmail.com>
✖   subject may not be misspelled: rlimits [spellcheck/subject]
✖   body may not be misspelled: rlimits [spellcheck/body]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Error: Process completed with exit code 1.
  • For spell check:
 101/133 pkg/unikontainers/types/types.go 8.98ms X
pkg/unikontainers/types/types.go:74:2 - Unknown word (Rlimits)
102/133 pkg/unikontainers/unikernels/linux.go 10.94ms X
pkg/unikontainers/unikernels/linux.go:317:37 - Unknown word (Rlimits)
103/133 pkg/unikontainers/unikernels/mewz.go 3.35ms
104/133 pkg/unikontainers/unikernels/mirage.go 3.72ms
105/133 pkg/unikontainers/unikernels/rumprun.go 5.97ms
106/133 pkg/unikontainers/unikernels/unikernel.go 5.01ms
107/133 pkg/unikontainers/unikernels/unikraft.go 6.27ms
108/133 pkg/unikontainers/unikernels/utils.go 3.47ms
109/133 pkg/unikontainers/unikontainers.go 42.30ms X
pkg/unikontainers/unikontainers.go:282:20 - Unknown word (Rlimits)
pkg/unikontainers/unikontainers.go:283:37 - Unknown word (Rlimits)
pkg/unikontainers/unikontainers.go:284:14 - Unknown word (Rlimits)
pkg/unikontainers/unikontainers.go:284:41 - Unknown word (Rlimits)

@codesmith25103 codesmith25103 force-pushed the Issue312 branch 6 times, most recently from 8d58b89 to fb24736 Compare December 23, 2025 16:00
This extracts the rlimits from the OCI spec in the unikontainer
logic and appends them to the UCS configuration block generated
in linux.go. This allows the guest init process (urunit) to
enforce resource limits.

Signed-off-by: Sankalp <sankalp25103@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@cmainas cmainas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @codesmith25103 , in order for these changes to be effective, we also need to update urunit to parse the updated config and apply the rlimits to the process. Therefore, we can not merge this without urunit supporting them. If you want you can also try to implement the necessary changes in urunit too. Otherwise, I will work on it when I find time to do so.

@codesmith25103
Copy link
Copy Markdown
Contributor Author

@cmainas I will try to update urunit and will update this PR.
Thank You

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions Bot added the Stale label Feb 23, 2026
@github-actions
Copy link
Copy Markdown

This PR was closed because it has been stalled for 75 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass rlimits to urunit

2 participants