fix(utils): perform extra handling of QueueProxy container#451
fix(utils): perform extra handling of QueueProxy container#451ishaanxgupta wants to merge 1 commit intourunc-dev:mainfrom
Conversation
✅ Deploy Preview for urunc canceled.
|
|
@cmainas please have a look |
|
Hello @ishaanxgupta , could you also set up a knative environment and test this out? You can find a tutorial here https://urunc.io/tutorials/knative/ |
Hi @cmainas I had already completed the setup and tested on it, will share the testing screenshots |
|
Hello @ishaanxgupta , have you tested this? |
|
Hi @cmainas yes have tested this one |
|
Great! Could you please rebase over main, so we can merge it? |
b3df41d to
5046191
Compare
|
@cmainas done please have a look, rebased this one 😊 |
5046191 to
64c0b15
Compare
|
Could you please rebase once more? |
64c0b15 to
52a4431
Compare
done |
Add extra check in handleQueueProxy() so it only appends readinessProbeEnv when it’s non-empty. Fixes urunc-dev#419 Signed-off-by: Ishaan Gupta <ishaankone@gmail.com>
52a4431 to
49ecf93
Compare
|
Hi @cmainas can we merge this? |
|
Hello @ishaanxgupta , yes, the PR is fine, but the CI fails. Therefore, as soon as the CI checks finally pass, we can merge it. |

Description
Add extra check in handleQueueProxy() so it only appends readinessProbeEnv when it’s non-empty.
Related issues
Fixes #419
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).