Skip to content

fix(ci): propagate closing keywords to merge PR body#559

Open
IrvingMg wants to merge 1 commit intourunc-dev:mainfrom
IrvingMg:auto-close-linked-issues
Open

fix(ci): propagate closing keywords to merge PR body#559
IrvingMg wants to merge 1 commit intourunc-dev:mainfrom
IrvingMg:auto-close-linked-issues

Conversation

@IrvingMg
Copy link
Copy Markdown
Contributor

Description

Related issues

How was this tested?

Full testing requires an actual PR merge workflow run.

LLM usage

Claude Opus 4.6

Checklist

  • I have read the contribution guide.
  • The linter passes locally (make lint).
  • The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
  • If LLMs were used: I have read the llm policy.

Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 13, 2026

Deploy Preview for urunc canceled.

Name Link
🔨 Latest commit e951dd0
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/69dcb78a3fd77c000814c190

@cmainas
Copy link
Copy Markdown
Contributor

cmainas commented Apr 20, 2026

Hello @IrvingMg ,

just to keep you updated, I will need to test this in a forked repository, so it might take some time for the review.

@cmainas
Copy link
Copy Markdown
Contributor

cmainas commented Apr 27, 2026

Hello @IrvingMg ,

I played around a bit with this PR. Unfortunately, It seems we are still missing something and the issues do not close automatically. I have create anew repository to test these changes https://github.com/urunc-dev/urunc_test . The changes of this PR have have addedd the respective message

This PR was automatically created by GitHub Actions to merge changes from main-pr8 into main.
Closes https://github.com/urunc-dev/urunc_test/issues/1

in urunc-dev/urunc_test#9 but the issue is still open.

In the repository setting the "Auto-close issues with merged linked pull requests " is enabled.

@IrvingMg
Copy link
Copy Markdown
Contributor Author

Thanks for testing this, @cmainas!

Looking at this discussion (https://github.com/orgs/community/discussions/24869#discussioncomment-3245678), it seems the missing piece might be the permissions of urunc-bot. Since the bot is the one merging the PR, GitHub treats it as the user who should also close the issue.

However, from the output of gh api /apps/urunc-bot, it looks like the bot doesn’t have permission to manage issues:

"permissions": {
  "actions": "write",
  "administration": "write",
  "contents": "write",
  "metadata": "read",
  "pull_requests": "write",
  "workflows": "write"
}

So it probably can’t close the issue after merging, and adding issues: write permission to the bot should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-close linked issues when external PRs are merged via bot

2 participants