chore(lint): run all CI linters locally via make targets#563
Open
IrvingMg wants to merge 1 commit intourunc-dev:mainfrom
Open
chore(lint): run all CI linters locally via make targets#563IrvingMg wants to merge 1 commit intourunc-dev:mainfrom
IrvingMg wants to merge 1 commit intourunc-dev:mainfrom
Conversation
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Contributor
|
Hello @IrvingMg , I have tested this out and it works well. A couple of questions / comments:
|
Contributor
Author
|
Hey @cmainas, thanks for giving it a try. About keeping the official actions in CI, that sounds good to me. We can keep this issue focused on local development. Since the custom npm image should be rebuilt when something changes in the linters directory, the risk of differences between CI and local setup should stay low. About where the linters should live, those configs are still used by the CI workflows, so they need to stay close to CI in some way. It probably makes sense to keep them in .github/linters/ so we don’t need to update workflow paths without a good reason. That said, I don’t have a strong opinion here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add per-tool
make lint_*targets and amake lintumbrella that run all four CI linters (golangci-lint, cspell, commitlint, license-eye) locally via containers, so contributors can catch all CI lint failures before pushing.Notes:
linters-npm:v0.1.0).Related issues
maketarget to run all CI linters locally #491How was this tested?
Ran all lint targets together via
make lint, and individually usingmake lint_*.LLM usage
Claude Opus 4.6
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).