CHORE: remove cancelled() checks from vm_test workflow#582
Open
kaizakin wants to merge 1 commit intourunc-dev:mainfrom
Open
CHORE: remove cancelled() checks from vm_test workflow#582kaizakin wants to merge 1 commit intourunc-dev:mainfrom
kaizakin wants to merge 1 commit intourunc-dev:mainfrom
Conversation
Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Contributor
|
Hello @kaizakin , thank you for this PR, do you have a link to the actions in your fork? |
Author
|
Hey @cmainas thanks for checking out. here's the link to the action run https://github.com/kaizakin/urunc/actions/runs/25074394005/job/73463209304 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
if: ${{ !cancelled() }}condition invm_test.ymlenabled the tests to run even if any of the previous steps failed.Related issues
How was this tested?
tested this by intentionally changing the firecraker release url and triggered a workflow in my fork.
once the firecracker step failed further jobs were skipped.
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).