Skip to content

CHORE: remove cancelled() checks from vm_test workflow#582

Open
kaizakin wants to merge 1 commit intourunc-dev:mainfrom
kaizakin:fix/tests
Open

CHORE: remove cancelled() checks from vm_test workflow#582
kaizakin wants to merge 1 commit intourunc-dev:mainfrom
kaizakin:fix/tests

Conversation

@kaizakin
Copy link
Copy Markdown

@kaizakin kaizakin commented Apr 28, 2026

Description

if: ${{ !cancelled() }} condition in vm_test.yml enabled the tests to run even if any of the previous steps failed.

Related issues

How was this tested?

tested this by intentionally changing the firecraker release url and triggered a workflow in my fork.

once the firecracker step failed further jobs were skipped.

image

LLM usage

N/A

Checklist

  • I have read the contribution guide.
  • The linter passes locally (make lint).
  • The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
  • If LLMs were used: I have read the llm policy.

Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 28, 2026

Deploy Preview for urunc canceled.

Name Link
🔨 Latest commit c473ee2
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/69f10b4826fd6b0008baf4f9

@kaizakin kaizakin marked this pull request as ready for review April 28, 2026 20:00
@cmainas
Copy link
Copy Markdown
Contributor

cmainas commented Apr 29, 2026

Hello @kaizakin ,

thank you for this PR, do you have a link to the actions in your fork?

@kaizakin
Copy link
Copy Markdown
Author

Hey @cmainas thanks for checking out.

here's the link to the action run https://github.com/kaizakin/urunc/actions/runs/25074394005/job/73463209304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not run the e2e tests if a setup action in the workflow fails

2 participants