perf: optimize FormatNsenterInfo string building#583
Open
hemang1404 wants to merge 1 commit intourunc-dev:mainfrom
Open
perf: optimize FormatNsenterInfo string building#583hemang1404 wants to merge 1 commit intourunc-dev:mainfrom
hemang1404 wants to merge 1 commit intourunc-dev:mainfrom
Conversation
This commit replaces strings.Builder with bytes.Buffer to prevent an unnecessary intermediate string to byte slice allocation. Fixes: urunc-dev#501 Signed-off-by: hemang1404 <hemangsharrma@gmail.com>
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the namespace info formatting process by replacing
strings.Builderwithbytes.BufferinFormatNsenterInfo. This eliminates an unnecessary intermediate allocation and copy step when converting the string to a byte slice, saving 2 allocations per operation.Related issues
How was this tested?
go build ./...passes to ensure type compatibility with thebytemsgstruct.LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).