Cleanup and fix workflows for adding git trailers#586
Open
Conversation
✅ Deploy Preview for urunc canceled.
|
cmainas
force-pushed
the
fix_add_git_trailers
branch
from
199c9cf to
18cb236
Compare
Clean up the workflows that add git trailers after an approval of a review. In particular: - move the check if the PR can get rebased a job condition - remove duplicate step for adding git trailers and setting up git, since this takes place inside the reusable action for the git trailers. Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clean up the workflows that add git trailers after an approval of a review. In particular:
Moreover, update the reference for the reusable action pointing to an updated version that fixes the issue with multiple names and also adds a check if a reviewer or approver was not found. In case they are not found, the action fails and therefore the push to main will not take place.
Related issues
How was this tested?
In a forked repository. Here is the action with a user that specifies an entry in contributors file with more than two words in the name field.
The action that fails if no reviewer or approver was found https://github.com/urunc-dev/urunc_test/actions/runs/25101512205/job/73551668496
The action that succeeds: https://github.com/urunc-dev/urunc_test/actions/runs/25102831636/job/73556303675
LLM usage
Assisted by Opus 4.6 through Copilot.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).