Skip to content

test: add unit tests for resolveAgainstBase#592

Open
Shreya2005-2005 wants to merge 1 commit intourunc-dev:mainfrom
Shreya2005-2005:test/add-resolve-against-base-tests
Open

test: add unit tests for resolveAgainstBase#592
Shreya2005-2005 wants to merge 1 commit intourunc-dev:mainfrom
Shreya2005-2005:test/add-resolve-against-base-tests

Conversation

@Shreya2005-2005
Copy link
Copy Markdown

@Shreya2005-2005 Shreya2005-2005 commented Apr 30, 2026

Description

Adds unit tests for the resolveAgainstBase function in pkg/unikontainers/utils.go.
This function had no test coverage. The tests cover:

  • absolute path returned unchanged
  • relative path joined with absolute base
  • relative path joined with relative base

Related issues

How was this tested?

Ran the unit tests locally using:
go test ./pkg/unikontainers/... -v -run TestResolveAgainstBase
All 3 test cases passed.

LLM usage

Claude Sonnet 4.6 was used to assist in understanding the codebase and test structure.
All generated code was reviewed and understood before submission.

Checklist

  • I have read the contribution guide.
  • The linter passes locally (make lint).
  • The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
  • If LLMs were used: I have read the llm policy.

Signed-off-by: Shreya2005-2005 <bhakatmistu2005@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 30, 2026

Deploy Preview for urunc canceled.

Name Link
🔨 Latest commit 036144a
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/69f2e79097e5780008897449

@cmainas
Copy link
Copy Markdown
Contributor

cmainas commented Apr 30, 2026

Hello @Shreya2005-2005 ,

thank you for submitting this PR. Please read the contribution guide and update your PR.

@Shreya2005-2005
Copy link
Copy Markdown
Author

Hello @Shreya2005-2005 ,

thank you for submitting this PR. Please read the contribution guide and update your PR.

Sure, made the changes according to the PR template could you take a look again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more unit tests

2 participants