test: add unit tests for resolveAgainstBase#592
Open
Shreya2005-2005 wants to merge 1 commit intourunc-dev:mainfrom
Open
test: add unit tests for resolveAgainstBase#592Shreya2005-2005 wants to merge 1 commit intourunc-dev:mainfrom
Shreya2005-2005 wants to merge 1 commit intourunc-dev:mainfrom
Conversation
Signed-off-by: Shreya2005-2005 <bhakatmistu2005@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Contributor
|
Hello @Shreya2005-2005 , thank you for submitting this PR. Please read the contribution guide and update your PR. |
Author
Sure, made the changes according to the PR template could you take a look again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for the
resolveAgainstBasefunction inpkg/unikontainers/utils.go.This function had no test coverage. The tests cover:
Related issues
How was this tested?
Ran the unit tests locally using:
go test ./pkg/unikontainers/... -v -run TestResolveAgainstBaseAll 3 test cases passed.
LLM usage
Claude Sonnet 4.6 was used to assist in understanding the codebase and test structure.
All generated code was reviewed and understood before submission.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).