Show why urunc falls back to urunc.json#593
Closed
mugiwaraluffy56 wants to merge 1 commit intourunc-dev:mainfrom
Closed
Show why urunc falls back to urunc.json#593mugiwaraluffy56 wants to merge 1 commit intourunc-dev:mainfrom
mugiwaraluffy56 wants to merge 1 commit intourunc-dev:mainfrom
Conversation
Signed-off-by: puneeth_aditya_5656 <myakampuneeth@gmail.com>
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Hello @mugiwaraluffy56 , please open an issue before submitting a PR. The PR is not the place to discuss about new features, suggestions or bug reports. We will review only PRs which are associated with a validated issue. |
Author
sorry @cmainas, I wont repeat this again. I want to join the urunc community and contribute as much as i can to this amazing project :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes the config fallback path easier to understand when urunc does not get a complete config from OCI annotations.
If the required annotations are missing or incomplete, urunc now logs the missing fields before trying
urunc.json. It also logs which config source it ended up using. That should make it easier to debug containerd or Docker setups where image annotations are not reaching the OCI runtime.I also added tests for the missing required field list and updated the packaging docs with a short note about the fallback diagnostics.
Related issues
None. This is a small diagnostic improvement.
How was this tested?
GOOS=linux go test -exec=/usr/bin/true ./pkg/unikontainersGOOS=linux go test -exec=/usr/bin/true ./pkg/...ARCH=arm64 CNTR_OPTS='run --rm' make lintNative
go teston this macOS host cannot build these Linux runtime packages directly because of Linux-only syscall and netlink usage.LLM usage
Assisted by GPT-5.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).