Report BUILDER_FALLBACK metric when falling back to local builder#87
Open
adityamaru wants to merge 5 commits intomainfrom
Open
Report BUILDER_FALLBACK metric when falling back to local builder#87adityamaru wants to merge 5 commits intomainfrom
adityamaru wants to merge 5 commits intomainfrom
Conversation
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
pbardea
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
startBlacksmithBuilder()fails and falls back to a local builder, we now report aBUILDER_FALLBACKfailure viareportBuildPushActionFailure()before logging the warning. This lets us track how often users experience fallbacks as a distinct event from the underlying root cause (e.g.BUILDER_STARTUP).How it works:
BUILDER_FALLBACKto the type union inreportBuildPushActionFailure()insrc/reporter.tsstartBlacksmithBuilder()insrc/main.ts, after thenofallbackcheck but before the warning log and returnThe reporter already handles its own errors internally (catches and warns), so a failure to report the metric won't block the fallback path. The companion PR in
useblacksmith/webaddsBUILDER_FALLBACKto the backend validation rule and two new Grafana panels to the Docker Overview dashboard.View Codesmith session