fix: prevent base logo color rendering as terminal background in half-block cells#221
Open
sachiniyer wants to merge 1 commit intomainfrom
Open
fix: prevent base logo color rendering as terminal background in half-block cells#221sachiniyer wants to merge 1 commit intomainfrom
sachiniyer wants to merge 1 commit intomainfrom
Conversation
…-block cells When a Base pixel (Color::Reset) lands in the background slot of a half-block cell alongside an Active/Complete pixel, it resets to the terminal's default background instead of the default foreground (the intended base logo color). Fix by flipping the glyph from ▀ to ▄ so Base stays in the foreground position where Color::Reset is correct. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Basepixel (Color::Reset) lands in the background slot of a half-block cell alongside anActive/Completepixel, it resets to the terminal's default background instead of the default foreground (the intended base logo color), creating a visible hole at the scan boundary.▀to▄whenbottom_style == Base, keepingColor::Resetin the foreground position where it correctly means "default foreground."apply_halfblock_cellfunction for testability, and added 3 new tests that verify all 16 style combinations against a real ratatuiCell.Test plan
base_pixel_never_rendered_as_background_color— exhaustively checks all 16 style combos, assertingColor::Resetnever appears as bg when aBasepixel is onactive_top_base_bottom_renders_correctly— verifies the specific buggy case uses▄with correct fg/bgbase_top_active_bottom_renders_correctly— verifies the already-correct symmetric case still works🤖 Generated with Claude Code