refactor: remove getminimalprojectbyname where possible#390
Merged
Conversation
shreddedbacon
force-pushed
the
less-minimals
branch
from
6b7cacb to
399ce5c
Compare
CGoodwin90
approved these changes
Oct 17, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Checklist
Not all roles can use
GetMinimalProjectByNamedue to theopenshiftlookup performed in that query.This uses changes in machinery to update the functions that used to require the project ID to now accept project name, this includes a minimal projectByName that just gets the project name and id now which will work for any role that has the permission to view the project. See uselagoon/machinery#74 (now available in v0.0.30)