simplify ssh conn string#461
Merged
Merged
Conversation
shreddedbacon
approved these changes
Aug 14, 2025
* Only specify -p when the port != 22 * Only specify -t when non-standard prefix arguments (e.g. service=) will break the ssh auto-sensing of pty allocation.
The ssh-core service now uses a fixed host key so we don't need to continue generating an ssh string which ignores it.
4b2283a to
2527e0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two changes to SSH connection string generation:
only use
-tand-p NNwhen necessary, instead relying on ssh defaults.Before:
After:
stop using
-o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=noaltogether, now that ssh-core has a static host key.