Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2759 +/- ##
=======================================
Coverage 46% 46%
+ Complexity 6725 6724 -1
=======================================
Files 794 794
Lines 65923 65923
Branches 9888 9888
=======================================
+ Hits 30837 30839 +2
- Misses 32696 32700 +4
+ Partials 2390 2384 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR is to help diagnostics of issues during parser storage (and the implicit parser generation process below it).
One of the main issues we encounter when using the parser storage features is incompleteness of the specification as a whole (missing modules which are imported or extended but not represented). A bit of incompleteness improves efficiency (a lot), so users filter their lists of modules. This may lead to missing syntax rules eventually. The current PR makes filtering a builtin feature, and reports missing modules as warnings so things do not go south implicitly anymore.