Skip to content

Answerタグの改善 #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aster-void merged 3 commits into from
Oct 19, 2023
Merged

Answerタグの改善 #485

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60b00ab
"解答" -> "解答例"
aster-void Oct 18, 2023
08d8b47
解答例にタイトル付与可能
aster-void Oct 18, 2023
a14ba5e
made it look better
aster-void Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/components/Answer/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ import Details from "@theme/Details";
/**
* component that hide an answer
*/
export default function Answer({ children }) {
return <Details summary={<summary>解答</summary>}>{children}</Details>;
export default function Answer({ type = undefined, children }) {
Copy link
Copy Markdown
Contributor

@chvmvd chvmvd Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeというよりは、titleな気がする？

Copy link
Copy Markdown
Contributor

@chvmvd chvmvd Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この引数だけ見てもどういう引数かが、わからないんだよね...

Copy link
Copy Markdown
Contributor Author

@aster-void aster-void Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かに

Copy link
Copy Markdown
Contributor

@chvmvd chvmvd Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえず、マージしてからでいいや。

return (
<Details
summary={
type ? <summary>解答例: {type}</summary> : <summary>解答例</summary>
}
>
{children}
</Details>
);
}