Initial refactoring by Pazus #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made all possible properties final, others need additional refactoring narrowed availability of test methods down to package-private as public is not needed nor recommended for jUnit 5 tests
Pazus
force-pushed
the
pazus-init-refactor
branch
from
09baf0f to
9fbee99
Compare
pesse
approved these changes
Feb 19, 2019
| */ | ||
| public class Version implements Comparable<Version> { | ||
|
|
||
| public final static Version V3_0_0 = new Version("3.0.0", 3,0,0,null, true); |
Member
There was a problem hiding this comment.
I love the known versions! Maybe we could put the exact build numbers here - in addition to 3.1.3 version
public final static Version V3_0_2 = new Version("3.0.2", 3,0,2,938, true);
public final static Version V3_0_3 = new Version("3.0.3", 3,0,3,1266, true);
public final static Version V3_0_4 = new Version("3.0.4", 3,0,4,1372, true);
public final static Version V3_1_0 = new Version("3.1.0", 3,1,0,1849, true);
public final static Version V3_1_1 = new Version("3.1.1", 3,1,1,1868, true);
public final static Version V3_1_2 = new Version("3.1.2", 3,1,2,2134, true);
public final static Version V3_1_3 = new Version("3.1.3", 3,1,3,2398, true);
private final static Map<String, Version> knownVersions =
Stream.of(V3_0_0, V3_0_1, V3_0_2, V3_0_3, V3_0_4, V3_1_0, V3_1_1, V3_1_2, V3_1_3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated jUnit to 5.4 version
made all possible properties final, others need additional refactoring
narrowed availability of test methods down to package-private as public is not needed nor recommended for jUnit 5 tests