VAR_ID

src/Database/Adapter/MariaDB.php

@@ -1063,7 +1063,7 @@ protected function getSQLType(string $type, int $size, bool $signed = true): str
 
                 return "VARCHAR({$size})";
 
-            case Database::VAR_INTSTRING:
+            case Database::VAR_ID:
                 return 'INT UNSIGNED'; // Same as Primary Key Sqlite does not allow INT(11)
 
             case Database::VAR_INTEGER:  // We don't support zerofill: https://stackoverflow.com/a/5634147/2299554

src/Database/Adapter/Postgres.php

@@ -1057,7 +1057,9 @@ protected function getSQLType(string $type, int $size, bool $signed = true): str
                 return "VARCHAR({$size})";
                 break;
 
-            case Database::VAR_INTSTRING:
+            case Database::VAR_ID:
+                return 'INTEGER';
+
             case Database::VAR_INTEGER:  // We don't support zerofill: https://stackoverflow.com/a/5634147/2299554
 
                 if ($size >= 8) { // INT = 4 bytes, BIGINT = 8 bytes

src/Database/Adapter/SQL.php

@@ -344,6 +344,11 @@ public function getAttributeWidth(Document $collection): int
                         $total += 4; // INT takes 4 bytes
                     }
                     break;
+
+                case Database::VAR_ID:
+                    $total += 4;
+                    break;
+
                 case Database::VAR_FLOAT:
                     // DOUBLE takes 8 bytes
                     $total += 8;
@@ -363,9 +368,6 @@ public function getAttributeWidth(Document $collection): int
                     $total += 19; // 2022-06-26 14:46:24
                     break;
 
-                case Database::VAR_INTSTRING:
-                    $total += 8;
-                    break;
                 default:
                     throw new Exception('Unknown Type');
                     break;

src/Database/Database.php

@@ -22,10 +22,10 @@ class Database
     const VAR_STRING = 'string';
     // Simple Types
     const VAR_INTEGER = 'integer';
-    const VAR_INTSTRING = 'intstring';
     const VAR_FLOAT = 'double';
     const VAR_BOOLEAN = 'boolean';
     const VAR_DATETIME = 'datetime';
+    const VAR_ID = 'id';
 
     // Relationships Types
     const VAR_DOCUMENT = 'document';
@@ -758,7 +758,7 @@ public function createAttribute(string $collection, string $id, string $type, in
             case self::VAR_FLOAT:
             case self::VAR_BOOLEAN:
             case self::VAR_DATETIME:
-            case self::VAR_INTSTRING:
+            case self::VAR_ID:
             break;
             default:
                 throw new Exception('Unknown attribute type: ' . $type);
@@ -1997,8 +1997,8 @@ public function casting(Document $collection, Document $document): Document
                     case self::VAR_INTEGER:
                         $node = (int)$node;
                         break;
-                    case self::VAR_INTSTRING:
-                        // let's keeps it string at this point as it comes out from the DB can be used by all
+                    case self::VAR_ID:
+                        // Not sure, maybe string as it fetched from DB?
                         break;
                     case self::VAR_FLOAT:
                         $node = (float)$node;

src/Database/Validator/Structure.php

@@ -252,8 +252,8 @@ public function isValid($document): bool
                     $validator = new Integer();
                     break;
 
-                case Database::VAR_INTSTRING:
-                    $validator = new Text(50, min: 0);
+                case Database::VAR_ID:
+                    $validator = new Text(20, min: 0);
                     break;
 
                 case Database::VAR_FLOAT:

tests/Database/Base.php

@@ -338,7 +338,7 @@ public function testCreateCollectionWithSchema()
             ]),
             new Document([
                 '$id' => ID::custom('collection_id'),
-                'type' => Database::VAR_INTSTRING,
+                'type' => Database::VAR_ID,
                 'size' => 0,
                 'required' => true,
                 'signed' => false,