Skip to content

Return new value atomically #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abnegate merged 5 commits into from
Jun 10, 2025
Merged

Return new value atomically #604

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
590a784
Return new value atomically
abnegate Jun 10, 2025
1c685bb
Fix ql
abnegate Jun 10, 2025
ae2055c
Return document
abnegate Jun 10, 2025
376945c
Fix tests
abnegate Jun 10, 2025
b4ab39b
Merge branch 'main' into feat-type-except
abnegate Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix ql
  • Loading branch information
@abnegate
abnegate committed Jun 10, 2025
commit 1c685bb8f8d65ddefa827951116cd44ef87978c1
4 changes: 2 additions & 2 deletions src/Database/Database.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5141,7 +5141,7 @@ public function increaseDocumentAttribute(
$document = Authorization::skip(fn () => $this->silent(fn () => $this->getDocument($collection->getId(), $id, forUpdate: true))); // Skip ensures user does not need read permission for this

if ($document->isEmpty()) {
return false;
throw new NotFoundException('Document not found');
}

$validator = new Authorization(self::PERMISSION_UPDATE);
Expand Down Expand Up @@ -5237,7 +5237,7 @@ public function decreaseDocumentAttribute(
$document = Authorization::skip(fn () => $this->silent(fn () => $this->getDocument($collection->getId(), $id, forUpdate: true))); // Skip ensures user does not need read permission for this

if ($document->isEmpty()) {
return false;
throw new NotFoundException('Document not found');
}

$validator = new Authorization(self::PERMISSION_UPDATE);
Expand Down
4 changes: 2 additions & 2 deletions src/Database/Mirror.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,12 +948,12 @@ public function renameIndex(string $collection, string $old, string $new): bool
return $this->delegate(__FUNCTION__, \func_get_args());
}

public function increaseDocumentAttribute(string $collection, string $id, string $attribute, int|float $value = 1, int|float|null $max = null): bool
public function increaseDocumentAttribute(string $collection, string $id, string $attribute, int|float $value = 1, int|float|null $max = null): int|float
{
return $this->delegate(__FUNCTION__, \func_get_args());
}

public function decreaseDocumentAttribute(string $collection, string $id, string $attribute, int|float $value = 1, int|float|null $min = null): bool
public function decreaseDocumentAttribute(string $collection, string $id, string $attribute, int|float $value = 1, int|float|null $min = null): int|float
{
return $this->delegate(__FUNCTION__, \func_get_args());
}
Expand Down