uudoc: print tldr.zip warning only once per process#10039
Merged
sylvestre merged 1 commit intouutils:mainfrom Jan 18, 2026
Merged
uudoc: print tldr.zip warning only once per process#10039sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
Contributor
|
Could you please add a test to verify this? Thanks |
Contributor
|
Per process? |
2d242c2 to
5af84b3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
Hi @sylvestre, since it's now in build.rs do I still need to do unit tests? What's the best way to do unit tests for build.rs? I made manual tests with |
Move the tldr.zip missing warning from runtime (uudoc.rs) to compile time (build.rs). This ensures the warning is printed only once during the build, instead of 100+ times when make calls uudoc separately for each utility. Fixes uutils#9940
5af84b3 to
83e37bb
Compare
Contributor
Author
|
@oech3 thanks, |
|
GNU testsuite comparison: |
Contributor
Author
|
I tried to run both GNU tests locally and they passed, maybe it needs a retry? |
Contributor
|
It is intermittent failure and merge main delays review. |
Contributor
I think you can count the word |
Contributor
|
Thankyou! |
mattsu2020
pushed a commit
to mattsu2020/coreutils
that referenced
this pull request
Jan 23, 2026
Move the tldr.zip missing warning from runtime (uudoc.rs) to compile time (build.rs). This ensures the warning is printed only once during the build, instead of 100+ times when make calls uudoc separately for each utility. Fixes uutils#9940
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the tldr.zip missing warning from runtime (
uudoc.rs) to compile time (build.rs). This ensures the warning is printed only once during the build, instead of 100+ times whenmakecallsuudocseparately for each utility.The Problem
From issue #9940:
The previous
OnceLockapproach did not work becausemake install-manpagesinvokesuudoc manpage <utility>as a separate process for each utility. Since each process has its own memory,OnceLockresets every time.The Fix
Check for
docs/tldr.zipinbuild.rsand emit acargo:warning=message at compile time:This prints the warning exactly once when
cargo build --features uudocruns, not during the 100+ runtime invocations.Testing
Build prints the warning once:
Running
uudoc manpagefor multiple utilities (simulatingmake install-manpages) prints no warnings:Fixes #9940