dirname: use Cow::Borrowed to avoid unnecessary heap allocations#10294
Merged
ChrisDryden merged 1 commit intouutils:mainfrom Jan 17, 2026
Merged
dirname: use Cow::Borrowed to avoid unnecessary heap allocations#10294ChrisDryden merged 1 commit intouutils:mainfrom
ChrisDryden merged 1 commit intouutils:mainfrom
Conversation
Contributor
sylvestre
commented
Jan 17, 2026
- remove useless comments
+ remove useless comments
|
GNU testsuite comparison: |
Collaborator
|
Did a search across the code base for other instances of this pattern and couldn't find any others, you'd think that slicing input data then calling .to_vec() in a Cow would be a Clippy rule |
Contributor
Author
|
I did not but I can nerd snip @samueltardieu |
Collaborator
|
I tried to look in clippy for this Cow stuff and for embedded cfg blocks #10296, couldn't even find suggestions in the issues queue |
Contributor
Well, that may be required if you need the |
mattsu2020
pushed a commit
to mattsu2020/coreutils
that referenced
this pull request
Jan 23, 2026
…ils#10294) + remove useless comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.