Skip to content

ci: move -no-metrics to COMMON_EMULATOR_OPTIONS#10385

Merged
sylvestre merged 1 commit intouutils:mainfrom
cakebaker:ci_android_no_metrics
Jan 20, 2026
Merged

ci: move -no-metrics to COMMON_EMULATOR_OPTIONS#10385
sylvestre merged 1 commit intouutils:mainfrom
cakebaker:ci_android_no_metrics

Conversation

@cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Jan 20, 2026

This PR is a follow-up to #10051 where I overlooked that we set the emulator-options in two steps (Build and Test and Create and cache emulator image) and so I set -no-metrics only once. Thus the warning about the metrics collection is still shown.

The PR moves the -no-metrics setting to the COMMON_EMULATOR_OPTIONS, which should remove the warning.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/stderr is no longer failing!
Congrats! The gnu test tests/tac/tac-2-nonseekable is no longer failing!
Congrats! The gnu test tests/tail/follow-stdin is no longer failing!

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 20, 2026

Merging this PR will improve performance by 4.44%

⚡ 1 improved benchmark
✅ 281 untouched benchmarks
⏩ 38 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory du_wide_tree[(5000, 500)] 1.3 MB 1.2 MB +4.44%

Comparing cakebaker:ci_android_no_metrics (92905b4) with main (56cf70d)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre sylvestre merged commit 56ec4be into uutils:main Jan 20, 2026
156 of 157 checks passed
@cakebaker cakebaker deleted the ci_android_no_metrics branch January 20, 2026 10:36
mattsu2020 pushed a commit to mattsu2020/coreutils that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants