Skip to content

install: warn --strip-program without -s#12956

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:ins-srtip-no-strip
Jun 19, 2026
Merged

install: warn --strip-program without -s#12956
sylvestre merged 1 commit into
uutils:mainfrom
oech3:ins-srtip-no-strip

Conversation

@oech3

@oech3 oech3 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Closes #12955

@oech3 oech3 force-pushed the ins-srtip-no-strip branch 2 times, most recently from 00d8d4e to c283789 Compare June 18, 2026 09:04
@github-actions

github-actions Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/pipe-f is now passing!

@oech3 oech3 marked this pull request as ready for review June 18, 2026 09:21
@oech3 oech3 force-pushed the ins-srtip-no-strip branch from c283789 to 06470e4 Compare June 18, 2026 13:32
sylvestre
sylvestre reviewed Jun 18, 2026
View reviewed changes
Comment thread src/uu/install/src/install.rs Outdated
let strip = matches.get_flag(OPT_STRIP);
let strip_program = match matches.get_one::<String>(OPT_STRIP_PROGRAM) {
Some(p) => {
if !strip && writeln!(std::io::stderr(), "install: WARNING: ignoring --strip-program option as -s option was not specified").is_err() {

@sylvestre sylvestre Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the translate!() macro

sylvestre
sylvestre requested changes Jun 18, 2026
View reviewed changes

@sylvestre sylvestre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test to make sure we won't regress

@oech3 oech3 marked this pull request as draft June 19, 2026 02:54
@oech3 oech3 force-pushed the ins-srtip-no-strip branch from 06470e4 to 4a953d9 Compare June 19, 2026 04:23
@codspeed-hq

codspeed-hq Bot commented Jun 19, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 3.21%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 321 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation du_all_wide_tree[(5000, 500)] 16.7 ms 16.1 ms +3.38%
⚡ Simulation du_max_depth_balanced_tree[(6, 4, 10)] 26.1 ms 25.3 ms +3.04%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing oech3:ins-srtip-no-strip (4a953d9) with main (5de3062)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@oech3 oech3 force-pushed the ins-srtip-no-strip branch from 4a953d9 to 0755217 Compare June 19, 2026 04:49
@oech3 oech3 marked this pull request as ready for review June 19, 2026 05:54
@oech3 oech3 requested a review from sylvestre June 19, 2026 05:54
@sylvestre sylvestre merged commit 3641a17 into uutils:main Jun 19, 2026
107 of 175 checks passed
@oech3 oech3 deleted the ins-srtip-no-strip branch June 19, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

install --strip-program without -s lacks an warning

2 participants

@oech3 @sylvestre