split: preliminary for distinguishing read/write errors (& reflink)#13105
split: preliminary for distinguishing read/write errors (& reflink)#13105oech3 wants to merge 1 commit into
Conversation
Merging this PR will improve performance by 9.76%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
|
GNU testsuite comparison: |
| Strategy::Bytes(chunk_size) => { | ||
| let mut writer = ByteChunkWriter::new(chunk_size, settings)?; | ||
| copy(&mut reader, &mut writer) | ||
| Ok(writer.copy(&mut reader, io_blksize)?) |
There was a problem hiding this comment.
While CodSpeed reported performance gain, this is double buffered by BufReader. I'll fix it at different PR.
GNU shows file path which caused I/O error. We need to separate out read/write instead of using
std::io::copyto do same thing. Addcopymethod.(This refactoring is useful for adding reflink support in the future BTW...)