Merged
Conversation
- Use modern conventions - Restrict the scope of unsafe - Do not use deprecated `std::mem::unitialized()` - Do not bake unicode into design
sylvestre
reviewed
Sep 14, 2021
| let mut len = buffer.len() as minwindef::DWORD; | ||
| if winbase::GetUserNameW(buffer.as_mut_ptr(), &mut len) == 0 { | ||
| return Err(Error::last_os_error()); | ||
| pub fn get_username() -> io::Result<OsString> { |
Contributor
There was a problem hiding this comment.
any idea with code coverage is 0 here?
Contributor
Author
There was a problem hiding this comment.
All the tests were disabled on Windows. I'll see if I can fix it.
blyxxyz
force-pushed
the
whoami-cleanup
branch
from
7cf4675 to
0a3785b
Compare
Contributor
Author
This confused me for a bit. The reason it says that is that (Not a problem for this PR.) |
Contributor
|
Keep in mind that the CI can be configured weirdly |
Contributor
Author
|
Yeah, there was already a workaround in place. I removed it to check if it was still necessary, and apparently it was, so I put it back. |
jhscheer
reviewed
Sep 15, 2021
Co-authored-by: Jan Scheer <jhscheer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::mem::unitialized()