Conversation
|
GNU testsuite comparison: |
|
please add this bench in https://github.com/uutils/coreutils/blob/main/src/uu/seq/BENCHMARKING.md |
Sure, done. I also stole some of the content I had written for #7458 (will rebase that MR on top of this one, I assume this one will be merged first). |
src/uu/seq/BENCHMARKING.md
Outdated
| by about 2 times for a floating point increment test case, leading to similar | ||
| performance compared with GNU `seq`: | ||
| ```shell | ||
| taskset -c 0 hyperfine -L seq seq,./seq-main,target/release/seq "{seq} 0 0.1 100000" |
There was a problem hiding this comment.
i don't think we need to document the results
just the commands
There was a problem hiding this comment.
Dropped.
I saw some results in some other BENCHMARKING.md so I just put them there... Might be nice to codify what's expected in those documentation files (maybe in CONTRIBUTING.md?). Not a big deal.
There was a problem hiding this comment.
sure, don't hesitate to make a proposition :)
|
GNU testsuite comparison: |
Use a BufWriter to wrap stdout: reduces the numbers of system calls, improves performance drastically (2x in some cases). Also document use cases in src/uu/seq/BENCHMARKING.md, and the optimization we have just done here.
|
GNU testsuite comparison: |
Use a BufWriter to wrap stdout: reduces the numbers of system calls, improves performance drastically (2x in some cases).
Fixes part of #7482, see this comment: #7482 (comment)
Thanks @mjguzik!
For floating point prints, we are now faster than GNU: