Merged
Conversation
|
GNU testsuite comparison: |
On Android CI, `sh` would point at a different flavor of shell shipped with termux (dash). The current umask test expects that `/system/bin/sh` is used though, so create a new function TestScenario:cmd_shell that runs a command in the default shell (that could be used in more tests). Fixes one part of uutils#7542.
For some unclear reason, Android _now_ sometimes returns an IsADirectory error, instead of PermissionDenied, when trying to execute `.`. Since this test really wants to test PermissionDenied, we try to execute a file in the fixture instead, that doesn't have exec permission. Also, limit this test to Unix. Fixes part of uutils#7542.
drinkcat
force-pushed
the
fix-android-ci
branch
from
ce61f4b to
6224586
Compare
See uutils#7542, it's not totally clear where the problem comes from, but blanking LD_PRELOAD set by termux seems to fix the problem (but introduces other issues. Let's just disable these tests for now.
drinkcat
force-pushed
the
fix-android-ci
branch
from
6224586 to
b142b9e
Compare
|
GNU testsuite comparison: |
Contributor
|
kudos :) |
Collaborator
Author
|
Yeah, seems worth it to have a green CI... we can always modify again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still no clue what changed, but I think this should fix some tests (last 2 commits are good fixes IMHO), and disable the others (still no idea what exactly is going on here...)
test_*: Disable tests that require setting rlimit on Android
See #7542, it's not totally clear where the problem comes from,
but blanking LD_PRELOAD set by termux seems to fix the problem
(but introduces other issues.
Let's just disable these tests for now.
test_env: Try to execute an empty file instead of
.For some unclear reason, Android now sometimes returns an
IsADirectory error, instead of PermissionDenied, when trying
to execute
..Since this test really wants to test PermissionDenied, we try
to execute a file in the fixture instead, that doesn't have
exec permission.
Also, limit this test to Unix.
Fixes part of #7542.
tests/common/util: Make sure test_altering_umask is run in correct shell
On Android CI,
shwould point at a different flavor of shellshipped with termux (dash).
The current umask test expects that
/system/bin/shis used though,so create a new function TestScenario:cmd_shell that runs a command
in the default shell (that could be used in more tests).
Fixes one part of #7542.