fix(sleep): use uucore's from_str to support parsing hex

[Qelxiros]

closes #7669

sleep now uses uucore's from_str instead of fundu to support hex parsing. This changes some error output (although it looks to be more in line with GNU, not less), so I changed the relevant tests as well. However, at first glance, it looks like it might be returning "empty string" in unexpected cases (e.g. '\n').

[drinkcat]

@Qelxiros Please rebase, #7648 made changes in this code recently.

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

[Copilot]

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

tests/by-util/test_sleep.rs:243

• The test function name suggests no error is expected, but the test asserts failure by calling .fails(). Consider renaming the test (for example, to test_sleep_when_input_has_trailing_whitespace_then_error) to more accurately reflect its behavior.

fn test_sleep_when_input_has_trailing_whitespace_then_no_error(#[case] input: &str) {

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

[drinkcat]

Thank you!! I think it looks quite good (I was afraid it'd look worse than that ,-P)! Just a few nits.

[drinkcat]

Oh, one more thing, please squash your commits into logical units (1 big commit would be ok, or maybe a couple: one for num_parser and one for parse_time), so that the git history stays somewhat clean.

[Qelxiros]

@drinkcat There should be an option to "squash and merge", which will combine all of my changes into one commit (possibly two with a merge commit). If it's easier for you, I'm happy to make one commit on my end.

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

[drinkcat]

Thanks! I think this looks good now.

@drinkcat There should be an option to "squash and merge", which will combine all of my changes into one commit (possibly two with a merge commit). If it's easier for you, I'm happy to make one commit on my end.

I'll let @sylvestre or @cakebaker comment.

[Qelxiros]

I've confirmed that this would close #7678, but the relevant tests aren't there yet. This implementation of from_str also has the potential to close #7670.

However, I don't want this PR to get too much scope creep. Should I add these two features here, or should I wait for this PR to get merged and then branch off of main for the other two?

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

[RenjiSann]

There should be an option to "squash and merge", which will combine all of my changes into one commit (possibly two with a merge commit). If it's easier for you, I'm happy to make one commit on my end.

As a good practice, I usually make 2 commits (unless I'm pushing a massive refactor which needs separate commits) : One for the changes, one for the tests. This is not possible to do using Github's interface, hence the request to squash the commits on your side.

Thank you !

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/sleep is no longer failing!

[sylvestre]

Congrats! The gnu test tests/misc/sleep is no longer failing!

kudos :)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/sleep is no longer failing!

[RenjiSann]

Thanks !

[sylvestre]

@Qelxiros as you touched this, maybe you could also remove the fundu dependency here too:

coreutils/src/uu/tail/src/args.rs

Line 231 in 82f354f

// Advantage of `fundu` over `Duration::(try_)from_secs_f64(source.parse().unwrap())`: