selinux: start the support of install#7908
Merged
cakebaker merged 2 commits intouutils:mainfrom May 22, 2025
Merged
Conversation
4237d36 to
71e3c19
Compare
|
GNU testsuite comparison: |
Contributor
Author
|
Congrats! The gnu test tests/install/install-C-selinux is no longer failing! Oh, this is unexpected :) |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces initial support for SELinux in the install utility by implementing features to preserve and set security contexts during file installation. The key changes include:
- Adding tests for SELinux functionality and updating spell-check hints in the test suite.
- Implementing new SELinux-related functions (contexts_differ and preserve_security_context) in the uucore library.
- Updating the install command to support new flags (-P for preserving context and -Z for setting context) and integrating SELinux functionality into the file copy process.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/by-util/test_install.rs | Updated spell-check hints, removed unimplemented test, added new SELinux tests. |
| src/uucore/src/lib/features/selinux.rs | Added functions for comparing and preserving SELinux contexts. |
| src/uu/install/src/install.rs | Integrated SELinux support into install behavior and file operations. |
| src/uu/install/Cargo.toml | Added selinux feature dependency for install. |
| Cargo.toml | Added selinux feature activation for install. |
Comments suppressed due to low confidence (1)
tests/by-util/test_install.rs:2017
- Verify if the substring 'ailed to set default file creation' is intentional or if it should be corrected to 'failed to set default file creation' to improve clarity.
.stderr_contains("ailed to set default file creation");
cakebaker
reviewed
May 11, 2025
cakebaker
reviewed
May 11, 2025
cakebaker
reviewed
May 11, 2025
71e3c19 to
71d79e6
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
May 11, 2025
cakebaker
reviewed
May 11, 2025
cakebaker
reviewed
May 11, 2025
cakebaker
reviewed
May 11, 2025
cakebaker
reviewed
May 11, 2025
71d79e6 to
baee8d7
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
May 14, 2025
cakebaker
reviewed
May 14, 2025
e25df00 to
2127de5
Compare
|
GNU testsuite comparison: |
2127de5 to
38861cc
Compare
|
GNU testsuite comparison: |
Contributor
Great, good work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.