README: fixed path in CONTRIBUTING file#9113
Closed
adarmaori wants to merge 1 commit intouutils:mainfrom
Closed
Conversation
The original path lead to files that don't exist (or have been renamed)
|
GNU testsuite comparison: |
cakebaker
reviewed
Nov 2, 2025
| - `src/main.rs`: contains only a single macro call | ||
| - `src/<util name>.rs`: the actual code for the utility | ||
| - `<util name>.md`: the documentation for the utility | ||
| - `src/uu/<util name>/README.md`: the documentation for the utility |
Contributor
There was a problem hiding this comment.
I would remove the entry, as there are only four utils with such a file:
$ find src/uu -name "README.md"
src/uu/dircolors/README.md
src/uu/tail/README.md
src/uu/split/README.md
src/uu/cp/README.md
The original <util name>.md-files have been removed. Their content is now part of the locales/en-US.ftl and locales/fr-FR.ftl files. So it might make sense to list those files instead.
sylvestre
requested changes
Dec 26, 2025
Contributor
sylvestre
left a comment
sylvestre
left a comment
There was a problem hiding this comment.
please add the review comments and reopen (or create a new pr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original path lead to files that don't exist (or have been renamed)