GNUmakefile: Support CARGO_BUILD_TARGET by oech3 · Pull Request #9223 · uutils/coreutils

oech3 · 2025-11-11T02:14:39Z

Fixes #9206 . Removes RUSTC_ARCH variable.

github-actions · 2025-11-11T02:35:15Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

oech3 · 2025-11-11T02:54:01Z

@XhstormR Would you review this? Tests are failing with

env --unset CARGO_BUILD_TARGET cargo build  ...
env: CARGO_BUILD_TARGET: No such file or directory
make: *** [build-uudoc] Error 127

github-actions · 2025-11-11T03:04:55Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

XhstormR · 2025-11-11T04:43:46Z

@oech3 MacOS' env dont support --unset flag, if you use --unset=CARGO_BUILD_TARGET, you will get a clearer error message.

└──❯ /usr/bin/env --unset CARGO_BUILD_TARGET
env: CARGO_BUILD_TARGET: No such file or directory
└──❯ /usr/bin/env --unset=CARGO_BUILD_TARGET
env: unsetenv nset=CARGO_BUILD_TARGET: Invalid argument

should use env CARGO_BUILD_TARGET= cargo build ...

user@c02fldw5md6m ~ %  /usr/bin/env USER=  sh -c 'echo "$USER"'

user@c02fldw5md6m ~ %  sh -c 'echo "$USER"'       
user

GNUmakefile

github-actions · 2025-11-11T08:29:20Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

oech3 · 2025-11-11T09:13:42Z

@Ecordonnier You will prefer this approarch instread of adding srange variable.

XhstormR · 2025-11-11T09:15:32Z

@oech3 Doesn't @unset CARGO_BUILD_TARGET simply mean clearing the CARGO_BUILD_TARGET environment variable?

I also think it's unnecessary to clear the CARGO_BUILD_TARGET variable. Instead, we should check the CARGO_BUILD_TARGET variable, and if it's set, add it to BUILDDIR, then we don't need to change the uudoc path, as I mentioned before:

ifdef CARGO_TARGET_DIR
BUILDDIR      := $(CARGO_TARGET_DIR)/${PROFILE}
else ifdef CARGO_BUILD_TARGET  
BUILDDIR      := $(BASEDIR)/target/$(CARGO_BUILD_TARGET)/${PROFILE}
else
BUILDDIR      := $(BASEDIR)/target/${PROFILE}
endif

oech3 · 2025-11-11T09:23:29Z

For simplity, does BUILDDIR := $(BASEDIR)/target/$(CARGO_BUILD_TARGET)/${PROFILE} cover the case CARGO_BUILD_TARGET is undefined?

XhstormR · 2025-11-11T09:59:07Z

@oech3 add else if check

ifdef CARGO_TARGET_DIR
BUILDDIR      := $(CARGO_TARGET_DIR)/${PROFILE}
+ else ifdef CARGO_BUILD_TARGET  
+ BUILDDIR      := $(BASEDIR)/target/$(CARGO_BUILD_TARGET)/${PROFILE}
else
BUILDDIR      := $(BASEDIR)/target/${PROFILE}
endif```

github-actions · 2025-11-11T10:17:30Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

oech3 · 2025-11-11T10:26:46Z

Undefined var is replaced by empty string. target//${PROFILE} (double slash) should be OK.

oech3 · 2025-11-11T10:38:30Z

Doesn't unset CARGO_BUILD_TARGET simply mean clearing the CARGO_BUILD_TARGET environment variable?

We need it since we use native uudoc.

github-actions · 2025-11-11T11:03:57Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

GNUmakefile

github-actions · 2025-11-14T04:46:06Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

GNUmakefile

codspeed-hq · 2025-11-17T01:48:21Z

Merging this PR will not alter performance

✅ 141 untouched benchmarks
⏩ 38 skipped benchmarks¹

_{Comparing oech3:cargo-build-target (967a428) with main (0d403a4)}

38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-11-17T01:54:18Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-17T09:53:00Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-17T10:45:03Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

oech3 · 2025-11-23T02:31:35Z

@sylvestre Is this OK to merge? 0 change for 1 week.

github-actions · 2025-11-25T00:34:56Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

github-actions · 2025-11-28T04:05:13Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/mv/hardlink-case is now passing!

oech3 · 2025-12-22T12:18:10Z

ok?

oech3 · 2026-01-10T12:53:11Z

I'm not hyper interested in this PR. But ping.

Ecordonnier · 2026-01-11T20:08:56Z

GNUmakefile

+# CARGO_BUILD_TARGET should be undefined for native (non-cross) build.
 BASEDIR       ?= $(shell pwd)
 ifdef CARGO_TARGET_DIR
 BUILDDIR 	  := $(CARGO_TARGET_DIR)/${PROFILE}


you should define BUILDDIR_UUDOC at lines 49 and 51 and take CARGO_TARGET_DIR into account. The problem with current state of the PR is that:

"$(BASEDIR)/target/$(PROFILE)/uudoc" is duplicated 4 times

it doesn't work with CARGO_TARGET_DIR:

env CARGO_TARGET_DIR=foobar CARGO_BUILD_TARGET=aarch64-unknown-linux-gnu make install-manpages PREFIX=/tmp/usr UTILS=true mkdir -p /tmp/usr/share/man/man1 /home/asteba/dev/coreutils/target/debug/uudoc manpage true > /tmp/usr/share/man/man1/true.1 /bin/sh: 1: /home/asteba/dev/coreutils/target/debug/uudoc: not found make: *** [GNUmakefile:389: install-manpages] Error 127 ...

ifdef CARGO_TARGET_DIR BUILDDIR := $(CARGO_TARGET_DIR)/${PROFILE} BUILDDIR_UUDOC := $(CARGO_TARGET_DIR)/${PROFILE} else BUILDDIR := $(BASEDIR)/target/$(CARGO_BUILD_TARGET)/${PROFILE} BUILDDIR_UUDOC := $(BASEDIR)/target/${PROFILE} endif

I have @unset CARGO_BUILD_TARGET && ${CARGO} build ${CARGOFLAGS} --bin uudoc .... Not enough?
I add BUILDDIR_UUDOC in any case.

It is not enough, setting @unset CARGO_BUILD_TARGET does not have an impact on CARGO_TARGET_DIR. The issue is that the build directory is not under BASEDIR when setting CARGO_TARGET_DIR to another directory.

Ecordonnier · 2026-01-11T20:11:59Z

I'm not hyper interested in this PR. But ping.

The PR is a good change. Please fix the one issue I mentioned and I'll merge it.

github-actions · 2026-01-12T11:55:42Z

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

Ecordonnier · 2026-01-12T13:24:01Z

@oech3 btw can you please correct your git email configuration? Your commits have no email configured for the Author, but they have an email for the Committer. This makes github show two different people for the commits ( see 97f8a08 for instance ):

Author: oech3 <>  2026-01-10 16:43:26
Committer: oech3 <79379754+oech3@users.noreply.github.com>  2026-01-12 09:13:08

oech3 · 2026-01-12T13:29:00Z

Can I set both empty?

Ecordonnier · 2026-01-12T13:30:02Z

Can I set both empty?

I would set both to 79379754+oech3@users.noreply.github.com , I think having an empty email is quite uncommon.

oech3 · 2026-01-12T13:31:54Z

Is @.noreply.* not auto-generated one at each commit?

Ecordonnier · 2026-01-12T13:35:40Z

Is @.noreply.* not auto-generated one at each commit?

No, if you go to https://github.com/settings/emails , at the bottom of the page you see your "public profile email". This email is permanent.

oech3 · 2026-01-12T13:37:45Z

This email is permanent.

OK.

Fixes uutils#9206 . Removes `RUSTC_ARCH` variable.

XhstormR reviewed Nov 11, 2025

View reviewed changes

GNUmakefile Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

oech3 force-pushed the cargo-build-target branch from 6134f2a to c83f76d Compare November 11, 2025 08:04

oech3 requested a review from XhstormR November 11, 2025 09:11

oech3 force-pushed the cargo-build-target branch from a9571ed to 2dda1fd Compare November 11, 2025 09:53

XhstormR approved these changes Nov 12, 2025

View reviewed changes

GNUmakefile Show resolved Hide resolved

renovate bot and others added 2 commits November 14, 2025 13:21

chore(deps): update rust crate crc-fast to v1.7.1

748d991

GNUmakefile: Support CARGO_BUILD_TARGET

88f1dd9

oech3 force-pushed the cargo-build-target branch from ef38ab4 to 88f1dd9 Compare November 14, 2025 04:22

Ecordonnier reviewed Nov 16, 2025

View reviewed changes

GNUmakefile Outdated Show resolved Hide resolved

Merge branch 'main' into cargo-build-target

a0c64c2

oech3 force-pushed the cargo-build-target branch from 384c335 to a0c64c2 Compare November 17, 2025 01:33

Merge branch 'main' into cargo-build-target

2627c1b

Merge branch 'main' into cargo-build-target

9f61a14

Merge branch 'main' into cargo-build-target

40c590b

oech3 added 2 commits November 25, 2025 09:18

GNUmakefile: Fix woording

c9b4c08

Merge branch 'main' into cargo-build-target

6da0004

Merge branch 'main' into cargo-build-target

135db2c

Merge branch 'main' into cargo-build-target

bd3aa71

Ecordonnier reviewed Jan 11, 2026

View reviewed changes

oech3 and others added 3 commits January 12, 2026 12:52

uudoc

1b32740

Merge branch 'main' into cargo-build-target

387fdba

uudoc

967a428

Ecordonnier self-requested a review January 12, 2026 07:38

Ecordonnier merged commit 40e50ba into uutils:main Jan 12, 2026
135 of 136 checks passed

oech3 deleted the cargo-build-target branch January 12, 2026 13:03

oech3 added a commit to oech3/coreutils that referenced this pull request Jan 13, 2026

GNUmakefile: Support CARGO_BUILD_TARGET (uutils#9223)

86f7ab8

Fixes uutils#9206 . Removes `RUSTC_ARCH` variable.

mattsu2020 pushed a commit to mattsu2020/coreutils that referenced this pull request Jan 23, 2026

GNUmakefile: Support CARGO_BUILD_TARGET (uutils#9223)

38655f8

Fixes uutils#9206 . Removes `RUSTC_ARCH` variable.

Uh oh!

Conversation

oech3 commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

oech3 commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

XhstormR commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

github-actions bot commented Nov 11, 2025

Uh oh!

oech3 commented Nov 11, 2025

Uh oh!

XhstormR commented Nov 11, 2025

Uh oh!

oech3 commented Nov 11, 2025

Uh oh!

XhstormR commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

oech3 commented Nov 11, 2025 via email

Uh oh!

oech3 commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

Uh oh!

codspeed-hq bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

github-actions bot commented Nov 17, 2025

Uh oh!

github-actions bot commented Nov 17, 2025

Uh oh!

github-actions bot commented Nov 17, 2025

Uh oh!

oech3 commented Nov 23, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

oech3 commented Dec 22, 2025

Uh oh!

oech3 commented Jan 10, 2026

Uh oh!

Ecordonnier Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Ecordonnier Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Ecordonnier Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ecordonnier commented Jan 11, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

Uh oh!

Ecordonnier commented Jan 12, 2026

Uh oh!

oech3 commented Jan 12, 2026

XhstormR commented Nov 11, 2025 •

edited

Loading

oech3 commented Nov 11, 2025 •

edited

Loading

codspeed-hq bot commented Nov 17, 2025 •

edited

Loading

Ecordonnier Jan 12, 2026 •

edited

Loading

Ecordonnier commented Jan 12, 2026 •

edited

Loading