parser: add binary support to determine_number_system and parse_size#9659
Merged
cakebaker merged 7 commits intouutils:mainfrom Dec 22, 2025
Merged
parser: add binary support to determine_number_system and parse_size#9659cakebaker merged 7 commits intouutils:mainfrom
cakebaker merged 7 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 15, 2025
tests/by-util/test_du.rs
Outdated
Comment on lines
1123
to
1127
| let threshold_bin = if cfg!(windows) { | ||
| "0b1101110000000" | ||
| } else { | ||
| "0b10011100010000" | ||
| }; |
Contributor
There was a problem hiding this comment.
What's the reason the threshold is lower on Windows? Please add a comment (or, if possible, use a threshold that works on any system).
Contributor
Author
There was a problem hiding this comment.
not sure, but it's there to match the logic on line 1095:
let threshold = if cfg!(windows) { "7K" } else { "10K" };
let me remove the custom threshold
cakebaker
reviewed
Dec 15, 2025
Contributor
cakebaker
left a comment
cakebaker
left a comment
There was a problem hiding this comment.
The other changes look fine.
|
GNU testsuite comparison: |
Contributor
|
Thanks for your PR! |
CrazyRoka
pushed a commit
to CrazyRoka/coreutils
that referenced
this pull request
Dec 28, 2025
…utils#9659) * parser: add binary support to determine_number_system and parse_size * docs * tests * tests: threshold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for binary number sizes.
Reopening #7829, duplicating as I don't have the permissions to reopen that one.