sort: gnu coreutils compatibility (sort.pl) by mattsu2020 · Pull Request #9862 · uutils/coreutils

mattsu2020 · 2025-12-26T10:58:12Z

We will make the necessary changes to ensure the GNU coreutils tests pass.

github-actions · 2025-12-26T11:36:29Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort is no longer failing!

src/uu/sort/src/sort.rs

sylvestre · 2025-12-26T12:58:53Z

it regressed a test

ChrisDryden · 2025-12-26T14:44:41Z

tests/by-util/test_sort.rs

 fn test_keys_invalid_field() {
    new_ucmd!()
        .args(&["-k", "1."])
        .fails()


I'd love to add .matches_gnu() to these: #9660

Its harder to review manually to validate that these tests are made in a way that matches the original.

github-actions · 2025-12-27T06:31:36Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort is no longer failing!

github-actions · 2025-12-27T07:29:51Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort is no longer failing!

sylvestre · 2025-12-27T09:07:48Z

Some jobs are failing

github-actions · 2025-12-27T10:25:26Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort is no longer failing!

github-actions · 2025-12-28T23:56:29Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort is no longer failing!
Congrats! The gnu test tests/tty/tty-eof is no longer failing!

sylvestre · 2026-01-05T06:37:44Z

this huge pr is hard to review :(
would it be possible to split a bit ? thanks

mattsu2020 · 2026-01-05T08:50:16Z

this huge pr is hard to review :( would it be possible to split a bit ? thanks

split the PR.
#10066
this PR is Unnecessary

mattsu2020 · 2026-01-05T09:37:47Z

split
#10068

github-actions · 2026-01-05T11:58:58Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort is no longer failing!

github-actions · 2026-01-14T00:04:55Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort is no longer failing!

codspeed-hq · 2026-01-16T03:54:04Z

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing mattsu2020:sort_sort.pl (0bee20f) with main (1c09c36)}

Summary

✅ 142 untouched benchmarks
⏩ 180 skipped benchmarks¹

180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Modify sort command to permit multiple -o/--output flags specifying the same file, matching GNU sort behavior. Previously, any multiple -o flags would error, but now only differing output files are rejected. Added test case for duplicate outputs.

…tters Changed ascii_case_insensitive_cmp to fold characters to uppercase instead of lowercase, ensuring that in ASCII case-insensitive sorting, letters are ordered before punctuation. Added tests to verify the correct behavior.

github-actions · 2026-01-21T11:49:26Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort is no longer failing!

src/uu/sort/src/sort.rs

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>

github-actions · 2026-01-27T07:10:54Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/sort/sort is no longer failing!

github-actions · 2026-01-27T07:32:35Z

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/sort/sort is no longer failing!

sylvestre · 2026-01-27T19:44:11Z

Congrats! The gnu test tests/sort/sort is no longer failing!

well done!

sylvestre reviewed Dec 26, 2025

View reviewed changes

src/uu/sort/src/sort.rs Outdated Show resolved Hide resolved

ChrisDryden reviewed Dec 26, 2025

View reviewed changes

ChrisDryden mentioned this pull request Dec 26, 2025

GNU coreutils 9.9: Detailed Test report 12/19 #9729

Closed

mattsu2020 requested a review from sylvestre January 5, 2026 06:32

mattsu2020 mentioned this pull request Jan 5, 2026

tests: extend CmdResult metadata for GNU comparison helpers #10066

Closed

mattsu2020 mentioned this pull request Jan 5, 2026

sort: refine error handling and localize field parsing errors #10068

Merged

mattsu2020 force-pushed the sort_sort.pl branch from 4cf08a9 to dc2952d Compare January 13, 2026 23:54

mattsu2020 force-pushed the sort_sort.pl branch from c054594 to a209604 Compare January 16, 2026 03:53

sylvestre force-pushed the sort_sort.pl branch from a209604 to 404c223 Compare January 18, 2026 18:00

mattsu2020 added 2 commits January 18, 2026 22:46

sylvestre force-pushed the sort_sort.pl branch from 404c223 to 3f16c72 Compare January 18, 2026 21:46

ChrisDryden mentioned this pull request Jan 20, 2026

GNU coreutils 9.9: Detailed Test report 01/20 #10390

Open

Merge branch 'main' into sort_sort.pl

5a2adfb

sylvestre reviewed Jan 26, 2026

View reviewed changes

src/uu/sort/src/sort.rs Outdated Show resolved Hide resolved

sylvestre reviewed Jan 26, 2026

View reviewed changes

src/uu/sort/src/sort.rs Outdated Show resolved Hide resolved

mattsu2020 and others added 3 commits January 27, 2026 08:18

Update src/uu/sort/src/sort.rs

8961468

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>

Update src/uu/sort/src/sort.rs

f60a82c

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>

Remove unnecessary closing brace in sort.rs

39df2f1

rustfmt

0bee20f

sylvestre merged commit 836e0cb into uutils:main Jan 27, 2026
130 checks passed

mattsu2020 deleted the sort_sort.pl branch January 27, 2026 23:05

moonfruit mentioned this pull request Feb 3, 2026

uutils-selected 0.6.0 moonfruit/homebrew-tap#453

Closed

Uh oh!

Conversation

mattsu2020 commented Dec 26, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

Uh oh!

sylvestre commented Dec 26, 2025

Uh oh!

ChrisDryden Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 27, 2025

Uh oh!

github-actions bot commented Dec 27, 2025

Uh oh!

sylvestre commented Dec 27, 2025

Uh oh!

github-actions bot commented Dec 27, 2025

Uh oh!

github-actions bot commented Dec 28, 2025

Uh oh!

sylvestre commented Jan 5, 2026

Uh oh!

mattsu2020 commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattsu2020 commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

codspeed-hq bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will not alter performance

Summary

Footnotes

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

sylvestre commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mattsu2020 commented Jan 5, 2026 •

edited

Loading

codspeed-hq bot commented Jan 16, 2026 •

edited

Loading