find: -printf: test octal escape before a multibyte char#727
Merged
Conversation
Regression test for the panic fixed in uutils#720/uutils#723: a `\NNN` octal escape immediately followed by a multibyte character (`\0€`) used to slice the format string mid-char and abort. Assert `-printf` emits the escape byte and the following character intact.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 35 35
Lines 7155 7155
Branches 375 375
=======================================
Hits 6573 6573
Misses 437 437
Partials 145 145 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #723 (fixes #720): adds the integration test requested in review.
-printfoctal escapes (\NNN) followed by a multibyte character used to slice the format string mid-char and panic. #723 fixed the parser; this adds atests/test_find.rsregression test assertingfind … -printf '\0€\n'succeeds and emits the escape byte plus the following character intact (00 e2 82ac 0a).